Conversation
Containers can now declare how DockTail Cloud monitors them, next to the rest of their labels: - docktail.cloud.ignore=true keeps the container out of Cloud monitoring: it is never reported as a service, checked or log-captured, and is listed in the container inventory marked label_ignored instead. - docktail.cloud.logs=off never captures incident log excerpts for it. - docktail.cloud.check.kind / .path / .expect-status shape the local check (a path or expected status implies http). The agent applies label intent itself: a label wins over the pushed config for its own setting, field by field, and settings without a label keep the cloud's value. Invalid values and unknown docktail.cloud.* keys are logged once per container and dropped, validated against the same bounds as cloud config, so a label can never pick a check destination. Valid intent is reported on each snapshot service (additive, omitempty proto fields) so the dashboard can show what is set by label. Nothing changes for the Tailscale reconciler.
marvinvr
added this pull request to stack #98
September 24, 2026 04:12
# Conflicts: # cloud/collector.go # docs/06-cloud.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #91 — merge that first (this branch starts from its head so the proto copy includes it).
Adds
docktail.cloud.*labels so a container can declare how DockTail Cloud monitors it, next to the rest of its labels:docktail.cloud.ignore=truelabel_ignoredand not watchable.docktail.cloud.logs=offdocktail.cloud.check.kind=tcp|httpdocktail.cloud.check.path=/healthzhttp).docktail.cloud.check.expect-status=204http).Model. The agent applies label intent itself: for its own setting a label wins over the cloud-pushed config, field by field, and a setting without a label keeps the cloud's value. Valid intent is reported per service in the snapshot (additive,
omitemptyproto fields:Service.LabelIntent,Container.LabelIgnored, plusSanitizeLabelIntent) so the dashboard can show what is set by label.Safety. Label values go through the same bounds as cloud config (
ValidateHTTPPath, status 100–599, tcp/http only); invalid values and unknowndocktail.cloud.*keys are logged once per container and dropped. The check destination still comes only from local discovery. A service whose backend protocol istcpkeeps its TCP check whatever the HTTP labels say. An ignored container's events are keyed by container name, and no logs are captured for it.Nothing changes for the Tailscale reconciler. Docs:
docs/04-labels.md(new "DockTail Cloud Labels" section) anddocs/06-cloud.md. Unit tests incloud/labels_test.go.Refs marvinvr/docktail-cloud#102