Skip to content

Refactor: explicit the fact the account name should be lowercase#21

Open
dehidehidehi wants to merge 1 commit intomarvk:masterfrom
dehidehi-work:v1.0.1/20_explicit-accountname-should-be-lowercase
Open

Refactor: explicit the fact the account name should be lowercase#21
dehidehidehi wants to merge 1 commit intomarvk:masterfrom
dehidehi-work:v1.0.1/20_explicit-accountname-should-be-lowercase

Conversation

@dehidehidehi
Copy link
Copy Markdown

@dehidehidehi dehidehidehi commented Jan 29, 2023

Great engine, thank you !

I would suggest making it explicit to provide a lowerCase account name when passing in the accountName into the LichessClientBuilder class.

Otherwise, the case sensitive equals() checks to determine who's turn it is (AI or player) always fails or returns null.

It was difficult for me to realize this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant