Skip to content

fix several requirements for command palette#7366

Open
AykhanAhmadli wants to merge 2 commits intorelease/1.33from
command-palette-quick-picks-fix
Open

fix several requirements for command palette#7366
AykhanAhmadli wants to merge 2 commits intorelease/1.33from
command-palette-quick-picks-fix

Conversation

@AykhanAhmadli
Copy link
Copy Markdown
Contributor

  • Palette no longer offers or applies quick picks. Locked follow-ups remain editable, matching existing app behavior.
  • Palette no longer offers quick picks while tabs are hidden behind the "Select an intake performer and a provider" alert.
  • Verified existing checks correctly suppress global items on their target pages; no duplication.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the EHR command palette behavior so quick picks/templates are only offered and applied when in-person charting is actually available, and suppresses quick-pick actions in read-only contexts (while keeping locked follow-ups editable per existing accessibility rules).

Changes:

  • Gate global quick picks + template application behind a new isChartingAvailable check (provider/intake selected as required, and not read-only).
  • Suppress radiology/immunization command palette quick picks and pending quick-pick application when the appointment is read-only.
  • Align quick-pick availability with the “Select an intake performer and a provider” blocking alert state.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
apps/ehr/src/hooks/useGlobalQuickPicks.ts Adds charting-availability gating for global quick picks and template application using encounter/provider selection and appointment accessibility.
apps/ehr/src/features/radiology/pages/CreateRadiologyOrder.tsx Disables command palette radiology quick picks and ignores pending quick picks when appointment is read-only.
apps/ehr/src/features/immunization/pages/ImmunizationOrderCreateEdit.tsx Disables command palette immunization quick picks and ignores pending quick picks when appointment is read-only.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/ehr/src/hooks/useGlobalQuickPicks.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants