Conversation
…tial commit) Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates Stripe terminal location configuration from a Location extension to a dedicated Device resource, updating both backend zambdas and the EHR UI to read/write terminal location IDs via Device.
Changes:
- Update
save-terminal-locationto create/update/delete aDevice(instead of mutatingLocation.extension). - Update
get-payment-locationsto returnstripeTerminalLocationIdby joiningLocationresults with terminal-configDeviceresources. - Add shared utils for finding the terminal-config
Deviceand extracting the terminal location identifier; update EHR types/tests and config seed data accordingly.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/zambdas/test/rcm/save-terminal-location.test.ts | Updates handler tests to validate create/update/delete behavior against Device resources. |
| packages/zambdas/src/rcm/payments/save-terminal-location/index.ts | Migrates persistence from Location extension to Device create/update/delete. |
| packages/zambdas/src/rcm/payments/get-payment-locations/index.ts | Adds stripeTerminalLocationId to response by querying terminal-config Device resources. |
| packages/utils/lib/fhir/payments.ts | Adds helpers to find terminal-config Device for a Location and read the terminal location identifier. |
| packages/utils/lib/fhir/constants.ts | Introduces new constants for device type + identifier system; marks old extension URL as deprecated. |
| config/oystehr/locations-and-schedules.json | Moves seeded terminal location data from a Location extension to a seeded Device resource. |
| apps/ehr/tests/component/PaymentLocationDetailPage.test.tsx | Updates mocked PaymentLocation objects to include stripeTerminalLocationId. |
| apps/ehr/src/rcm/state/payments/payments.api.ts | Extends PaymentLocation API type with stripeTerminalLocationId. |
| apps/ehr/src/pages/PaymentLocationDetailPage.tsx | Switches UI to consume stripeTerminalLocationId from API response instead of reading a Location extension. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com>
alexwillingham
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.