Skip to content

fix(acp): stream in-progress tool cards and still-running heartbeats #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matdev83 merged 3 commits into from
Aug 14, 2026
Merged

fix(acp): stream in-progress tool cards and still-running heartbeats #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6db2854
fix(acp): stream in-progress tool cards and still-running heartbeats
Aug 14, 2026
b0ffd95
fix(acp): guard None read_task before result()
Aug 14, 2026
2b06036
ci: diff architecture-check against PR commits only
Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/architecture-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ jobs:

steps:
- uses: actions/checkout@v5
with:
# Need merge-base history so PR diffs are commit-to-commit, not
# working-tree vs origin/base (CRLF checkout noise lists the whole repo).
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v6
Expand All @@ -26,9 +30,9 @@ jobs:
- name: Run architectural linter on changed files
run: |
if [ "${{ github.event_name }}" == "pull_request" ]; then
# Get list of changed Python files in the PR
git fetch origin ${{ github.base_ref }} --depth=1
CHANGED_FILES=$(git diff --name-only origin/${{ github.base_ref }} | grep "\.py$" || true)
# Get list of changed Python files in the PR (three-dot, commits only)
git fetch origin ${{ github.base_ref }}
CHANGED_FILES=$(git diff --name-only origin/${{ github.base_ref }}...HEAD | grep "\.py$" || true)
else
# Get list of changed Python files in the push
git fetch origin ${{ github.event.before }} --depth=1
Expand Down
Loading
Loading