Skip to content

completed tasks#545

Open
qlaudy wants to merge 4 commits intomate-academy:masterfrom
qlaudy:develop
Open

completed tasks#545
qlaudy wants to merge 4 commits intomate-academy:masterfrom
qlaudy:develop

Conversation

@qlaudy
Copy link
Copy Markdown

@qlaudy qlaudy commented Nov 7, 2025

etojeDenys
etojeDenys suggested changes Nov 7, 2025
View reviewed changes
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. disable page scrolling when the menu is open
image
  1. add a hover effect to these links
image

example:
image

  1. make sure your buttons follow this mockup. also, all buttons should be "button" instead of "div"
image
  1. this section should take up the full height of the screen (use vh)
image

qlaudy
qlaudy commented Nov 8, 2025
View reviewed changes
Copy link
Copy Markdown
Author

@qlaudy qlaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEMO LINK.

@qlaudy qlaudy requested a review from etojeDenys November 8, 2025 22:16
etojeDenys
etojeDenys suggested changes Nov 9, 2025
View reviewed changes
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

  1. this section does not have 100% of the screen height.
image
  1. page content should have a max width
image

qlaudy
qlaudy commented Nov 9, 2025
View reviewed changes
Copy link
Copy Markdown
Author

@qlaudy qlaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEMO LINK.

@qlaudy qlaudy requested a review from etojeDenys November 9, 2025 15:32
vitalii-bondarenko-ua
vitalii-bondarenko-ua approved these changes Nov 9, 2025
View reviewed changes
Copy link
Copy Markdown

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

1 more reviewer

@vitalii-bondarenko-ua vitalii-bondarenko-ua vitalii-bondarenko-ua approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qlaudy @etojeDenys @vitalii-bondarenko-ua