First try by IgnisVictima · Pull Request #2580 · mate-academy/jv-oop

IgnisVictima · 2026-04-27T07:29:18Z

No description provided.

mateacademy-ai-mentor

Review Summary

Your solution is approved with an educational note to help you progress. Great job implementing the OOP concepts correctly! Your abstract class Machine with its abstract methods, all three subclasses extending it properly, and the polymorphism in MainApp using an array of abstract references demonstrate solid understanding of inheritance and method overriding. However, there are style violations that need attention: [CHECKLIST ITEM #18] requires removing redundant empty lines after class declarations, method signatures, and method bodies in all files (Machine.java, MainApp.java, Bulldozer.java, Truck.java). Additionally, Machine.java is missing a trailing newline at the end of the file, which causes a Checkstyle NewlineAtEndOfFile error. These are formatting issues rather than logic problems, but fixing them will help your code pass CI checks and follow professional Java conventions. Keep up the good work with the functional implementation.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-04-27T07:31:48Z

@@ -0,0 +1,9 @@
+package core.basesyntax;
+
+public abstract class Machine {


Redundant empty line after class declaration - per checklist item #18, avoid empty lines after class declarations

mateacademy-ai-mentor · 2026-04-27T07:31:48Z

@@ -1,5 +1,17 @@
 package core.basesyntax;



Redundant empty line after package declaration. Per checklist #18, avoid empty lines after class declarations.

mateacademy-ai-mentor · 2026-04-27T07:31:48Z

 package core.basesyntax;

 public class MainApp {
+    public static void main(String[] args) {


Redundant empty line after class declaration. Per checklist #18, avoid empty lines after class declarations.

mateacademy-ai-mentor · 2026-04-27T07:31:48Z

 public class MainApp {
+    public static void main(String[] args) {

+        Machine buldozerMachine = new Bulldozer();


Redundant empty line after method signature. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:31:48Z

+        Machine buldozerMachine = new Bulldozer();
+        Machine truckMachine = new Truck();
+        Machine excavatorMachine = new Excavator();
+


Redundant empty line after method body. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:31:48Z

 public class MainApp {
+    public static void main(String[] args) {

+        Machine buldozerMachine = new Bulldozer();


Redundant empty line after method signature. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:31:48Z

+        Machine buldozerMachine = new Bulldozer();
+        Machine truckMachine = new Truck();
+        Machine excavatorMachine = new Excavator();
+


Redundant empty line after method body. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:31:49Z

@@ -1,5 +1,17 @@
 package core.basesyntax;



Redundant empty line after package declaration. Per checklist #18, avoid empty lines after class declarations.

mateacademy-ai-mentor · 2026-04-27T07:31:49Z

 package core.basesyntax;

 public class MainApp {
+    public static void main(String[] args) {


Redundant empty line after class declaration. Per checklist #18, avoid empty lines after class declarations.

mateacademy-ai-mentor · 2026-04-27T07:31:49Z

 public class MainApp {
+    public static void main(String[] args) {

+        Machine buldozerMachine = new Bulldozer();


Redundant empty line after method signature. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:31:53Z

+        Machine buldozerMachine = new Bulldozer();
+        Machine truckMachine = new Truck();
+        Machine excavatorMachine = new Excavator();
+


Redundant empty line after method body. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:31:53Z

 public class MainApp {
+    public static void main(String[] args) {

+        Machine buldozerMachine = new Bulldozer();


Redundant empty line after method signature. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:31:53Z

+        Machine buldozerMachine = new Bulldozer();
+        Machine truckMachine = new Truck();
+        Machine excavatorMachine = new Excavator();
+


Redundant empty line after method body. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:31:53Z

@@ -1,5 +1,17 @@
 package core.basesyntax;



Redundant empty line after package declaration. Per checklist #18, avoid empty lines after class declarations.

mateacademy-ai-mentor · 2026-04-27T07:31:53Z

 package core.basesyntax;

 public class MainApp {
+    public static void main(String[] args) {


Redundant empty line after class declaration. Per checklist #18, avoid empty lines after class declarations.

mateacademy-ai-mentor · 2026-04-27T07:31:53Z

 public class MainApp {
+    public static void main(String[] args) {

+        Machine buldozerMachine = new Bulldozer();


Redundant empty line after method signature. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:31:53Z


+        Machine buldozerMachine = new Bulldozer();
+        Machine truckMachine = new Truck();
+        Machine excavatorMachine = new Excavator();


Redundant empty line after method body. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:31:53Z

 public class MainApp {
+    public static void main(String[] args) {

+        Machine buldozerMachine = new Bulldozer();


Redundant empty line after method signature. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:31:53Z


+        Machine buldozerMachine = new Bulldozer();
+        Machine truckMachine = new Truck();
+        Machine excavatorMachine = new Excavator();


Redundant empty line after method body. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:31:53Z

+
+public class Bulldozer extends Machine {
+


This violates checklist item #18: redundant empty line after class declaration. Remove the empty line between public abstract class Machine { and the method.

mateacademy-ai-mentor · 2026-04-27T07:31:58Z

+public class Bulldozer extends Machine {
+
+    @Override
+    public void doWork() {


This violates checklist item #18: redundant empty line after public abstract void doWork();. Remove this empty line.

mateacademy-ai-mentor · 2026-04-27T07:31:58Z

+
+public class Bulldozer extends Machine {
+


This violates checklist item #18: redundant empty line after class declaration. Remove the empty line between public class Bulldozer extends Machine { and the method.

mateacademy-ai-mentor · 2026-04-27T07:31:58Z

+    @Override
+    public void doWork() {
+        System.out.println("Bulldozer started its work");
+    }


This violates checklist item #18: redundant empty line after method closing brace }. Remove this empty line.

mateacademy-ai-mentor · 2026-04-27T07:31:58Z

+
+public class Bulldozer extends Machine {
+


This violates checklist item #18: redundant empty line after class declaration. Remove the empty line between public class Excavator extends Machine { and the method.

mateacademy-ai-mentor · 2026-04-27T07:31:58Z

+    @Override
+    public void doWork() {
+        System.out.println("Bulldozer started its work");
+    }


This violates checklist item #18: redundant empty line after method closing brace }. Remove this empty line.

mateacademy-ai-mentor · 2026-04-27T07:31:58Z

+
+public class Bulldozer extends Machine {
+
+    @Override


This violates checklist item #18: redundant empty line after public static void main(String[] args) {. Remove this empty line.

mateacademy-ai-mentor · 2026-04-27T07:31:58Z

+
+    @Override
+    public void stopWork() {


This violates checklist item #18: redundant empty lines after variable declarations. Remove empty lines on lines 9 and 11.

mateacademy-ai-mentor · 2026-04-27T07:31:58Z

@@ -0,0 +1,14 @@
+package core.basesyntax;
+


Redundant empty line after package declaration. Per checklist #18, avoid empty lines after class declarations.

mateacademy-ai-mentor · 2026-04-27T07:31:58Z

+package core.basesyntax;
+
+public class Truck extends Machine {
+


Redundant empty line after class declaration. Per checklist #18, avoid empty lines after class declarations.

mateacademy-ai-mentor · 2026-04-27T07:31:58Z

+    @Override
+    public void doWork() {
+        System.out.println("Truck started its work");
+    }


Redundant empty line after method body. Per checklist #18, avoid empty lines after method signatures.

mateacademy-ai-mentor · 2026-04-27T07:32:02Z

+    public void doWork() {
+        System.out.println("Truck started its work");
+    }
+


Redundant empty line before second method. Per checklist #18, avoid empty lines after method signatures.

fetis-off

Good work!

IgnisVictima added 7 commits April 10, 2026 07:49

add Main.Class Machine and his heirs

5e3a358

fixed the style of the code

a2d85ea

used auto-formating

e877e2b

Trigger re-check by mateacademy-ai-mentor

692e991

Style: tiny formatting fix to trigger CI

abae700

Final

4bd1129

chore: remove accidental file

62fd053

mateacademy-ai-mentor suggested changes Apr 27, 2026

View reviewed changes

mateacademy-ai-mentor reviewed Apr 27, 2026

View reviewed changes

IgnisVictima added 2 commits April 27, 2026 09:33

IstFinal

b1e54d9

IsFinal

839d182

IgnisVictima requested a review from mateacademy-ai-mentor April 27, 2026 07:53

fetis-off approved these changes Apr 28, 2026

View reviewed changes

		@@ -0,0 +1,9 @@
		package core.basesyntax;

		public abstract class Machine {

		package core.basesyntax;

		public class Truck extends Machine {

Uh oh!

Conversation

IgnisVictima commented Apr 27, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fetis-off left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development