the task is done#2581
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your submission has a critical bug that must be fixed. The Truck.java class prints "Bulldozer is working" and "Bulldozer is stopping" messages instead of "Truck is working" and "Truck is stopping". This violates checklist item #2 which explicitly requires that messages indicate the correct machine type. Additionally, there are redundant empty lines after class declarations and method signatures in Bulldozer.java, Truck.java, and Excavator.java that violate checklist item #5. Please fix the message text in Truck.java to correctly print "Truck" and remove the redundant empty lines.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
done |
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. All core functional requirements are correctly implemented: the abstract Machine class, all three machine classes extending it, proper override of doWork() and stopWork() methods with correct English messages, and polymorphism using a Machine array in MainApp. The previous critical bug with Truck.java printing incorrect messages has been successfully fixed. The only remaining issues are minor style violations - redundant empty lines in Bulldozer.java after class/method declarations and an empty line in Machine.java before the closing brace. Per the checklist item #1, these empty lines after class declarations and method signatures are unnecessary and should be removed. While these are non-blocking style issues, fixing them will improve code cleanliness.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| package core.basesyntax; | ||
|
|
||
| public class Bulldozer extends Machine { | ||
|
|
There was a problem hiding this comment.
Redundant empty line after class declaration. Checklist item #1 states: 'We don't need them after class declaration or method signature.'
| package core.basesyntax; | ||
|
|
||
| public class Bulldozer extends Machine { | ||
|
|
There was a problem hiding this comment.
Redundant empty line after class declaration. Checklist item #1 states: 'We don't need them after class declaration or method signature.'
|
|
||
| public class Bulldozer extends Machine { | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Redundant empty line after doWork() method declaration. Checklist item #1 states: 'We don't need them after class declaration or method signature.'
|
|
||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Bulldozer is starting"); |
There was a problem hiding this comment.
Redundant empty line after stopWork() method declaration. Checklist item #1 states: 'We don't need them after class declaration or method signature.'
| public class Bulldozer extends Machine { | ||
|
|
||
| @Override | ||
| public void doWork() { |
There was a problem hiding this comment.
Redundant empty line after main method signature. Checklist item #1 states: 'We don't need them after class declaration or method signature.'
2 participants
No description provided.