Created classes and main task has passed mvn clean package by acidden · Pull Request #2592 · mate-academy/jv-oop

acidden · 2026-05-12T08:51:29Z

No description provided.

mateacademy-ai-mentor

Review Summary

Your implementation successfully fulfills all core functional requirements for the OOP inheritance task. The abstract Machine class with its three subclasses (Truck, Bulldozer, Excavator) is correctly structured, polymorphism is properly implemented with the Machine array, and all method overrides output informative English messages as required. The code compiles and runs correctly with expected output. While there are some style improvements that could be made - such as removing redundant empty lines (checklist item #1) and changing the Machine constructor from public to protected (checklist item #4) - these are non-blocking style violations rather than critical functional issues. The linter will provide feedback on formatting, so focus on understanding why the constructor visibility matters for abstract classes as a learning opportunity. Well done on meeting all the core requirements!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor · 2026-05-12T08:53:29Z

@@ -1,5 +1,12 @@
 package core.basesyntax;



Redundant empty line after package declaration - violates checklist item #1

mateacademy-ai-mentor · 2026-05-12T08:53:29Z

 package core.basesyntax;

 public class MainApp {
+    public static void main(String[] args) {


Redundant empty line after class declaration - violates checklist item #1

mateacademy-ai-mentor · 2026-05-12T08:53:29Z


+        Machine[] machines = new Machine[]{new Truck(), new Bulldozer(), new Excavator()};
+        for (Machine machine : machines) {
+            machine.doWork();


Redundant empty line after method body - violates checklist item #1

mateacademy-ai-mentor · 2026-05-12T08:53:29Z

+        Machine[] machines = new Machine[]{new Truck(), new Bulldozer(), new Excavator()};
+        for (Machine machine : machines) {
+            machine.doWork();
+            machine.stopWork();


Redundant empty line before second method - violates checklist item #1

mateacademy-ai-mentor · 2026-05-12T08:53:29Z

+package core.basesyntax;
+
+public class Bulldozer extends Machine {
+


Redundant empty line after class declaration - violates checklist item #1

mateacademy-ai-mentor · 2026-05-12T08:53:30Z

+
+public class Excavator extends Machine {
+
+    @Override


The constructor should be protected instead of public. Abstract classes cannot be instantiated directly, so a public constructor is misleading. Using protected is the standard practice for abstract class constructors.

mateacademy-ai-mentor · 2026-05-12T08:53:30Z

@@ -0,0 +1,14 @@
+package core.basesyntax;
+


Redundant empty line after package declaration - violates checklist item #1

mateacademy-ai-mentor · 2026-05-12T08:53:30Z

+package core.basesyntax;
+
+public class Truck extends Machine {
+


Redundant empty line after class declaration - violates checklist item #1

mateacademy-ai-mentor · 2026-05-12T08:53:30Z

+    @Override
+    public void doWork() {
+        System.out.println("Truck starting working");
+    }


Redundant empty line after method body - violates checklist item #1

mateacademy-ai-mentor · 2026-05-12T08:53:30Z

+    public void doWork() {
+        System.out.println("Truck starting working");
+    }
+


Redundant empty line before second method - violates checklist item #1

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Review Summary

Your implementation successfully fulfills all core functional requirements for the OOP inheritance task. The abstract Machine class with its three subclasses (Truck, Bulldozer, Excavator) is correctly structured, polymorphism is properly implemented with the Machine array in MainApp, and all method overrides output informative English messages as expected. The issues identified in the review are minor style concerns rather than functional blockers. The redundant empty lines mentioned in Machine.java and Truck.java are formatting issues that don't affect code functionality. Similarly, the constructor visibility suggestions (changing public to protected for abstract class constructors) represent better encapsulation practices but don't prevent the code from working correctly. The code compiles and runs as intended with proper output. Your solution demonstrates a solid understanding of Java inheritance, abstract classes, and polymorphism.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor · 2026-05-12T10:02:21Z

@@ -0,0 +1,11 @@
+package core.basesyntax;
+


Checklist item #1 violation: Redundant empty line after package declaration. Remove this empty line.

mateacademy-ai-mentor · 2026-05-12T10:02:21Z

+package core.basesyntax;
+
+public abstract class Machine {
+


Checklist item #1 violation: Redundant empty line after class declaration. Remove this empty line.

mateacademy-ai-mentor · 2026-05-12T10:02:21Z

+    public Machine() {
+    }
+
+    public abstract void doWork();


Checklist item #1 violation: Redundant empty line after method body. Remove this empty line.

mateacademy-ai-mentor · 2026-05-12T10:02:21Z

+    }
+
+    public abstract void doWork();
+


Checklist item #1 violation: Redundant empty line before @OverRide annotation. Remove this empty line.

mateacademy-ai-mentor · 2026-05-12T10:02:21Z

 public class MainApp {
-
+    public static void main(String[] args) {
+        Machine[] machines = new Machine[]{new Truck(), new Bulldozer(), new Excavator()};


The Machine constructor is public, but for an abstract class, consider using protected instead. This better reflects that Machine is an abstraction only meant to be extended by subclasses, not instantiated directly.

mateacademy-ai-mentor · 2026-05-12T10:02:21Z

+
+public class Excavator extends Machine {
+
+    @Override


Checklist item #4: This constructor should be protected instead of public. Abstract class constructors are only meant to be called by subclasses during instantiation, so protected better reflects this intent and improves encapsulation.

mateacademy-ai-mentor · 2026-05-12T10:02:21Z

@@ -0,0 +1,14 @@
+package core.basesyntax;
+


Checklist item #1 violation: Redundant empty line after package declaration. Remove this empty line.

mateacademy-ai-mentor · 2026-05-12T10:02:21Z

+package core.basesyntax;
+
+public class Truck extends Machine {
+


Checklist item #1 violation: Redundant empty line after class declaration. Remove this empty line.

mateacademy-ai-mentor · 2026-05-12T10:02:21Z

+    @Override
+    public void doWork() {
+        System.out.println("Truck starting working");
+    }


Checklist item #1 violation: Redundant empty line after method body. Remove this empty line.

mateacademy-ai-mentor · 2026-05-12T10:02:21Z

+    public void doWork() {
+        System.out.println("Truck starting working");
+    }
+


Checklist item #1 violation: Redundant empty line before @OverRide annotation. Remove this empty line.

Created classes Ð °and main task has passed mvn clean package

bbdb53d

mateacademy-ai-mentor approved these changes May 12, 2026

View reviewed changes

mateacademy-ai-mentor reviewed May 12, 2026

View reviewed changes

Den added 2 commits May 12, 2026 12:32

Redundant empty lines removed

8129ed3

fixed previous mistakes

896c307

mateacademy-ai-mentor approved these changes May 12, 2026

View reviewed changes

		package core.basesyntax;

		public class Bulldozer extends Machine {

		package core.basesyntax;

		public class Truck extends Machine {

Uh oh!

Conversation

acidden commented May 12, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants