Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on implementing the server! You've correctly used streams and the zlib module to handle file compression, and the error handling is solid.
However, some changes are needed regarding the output filename. The task requires specific file extensions for compressed files: .gz for gzip and .dfl for deflate. Currently, your implementation in src/createServer.js uses the full compression type (e.g., .gzip), which doesn't match the requirements.
Please adjust the logic to map the compressionType from the form to the correct file extension before setting the Content-Disposition header. After you've made this adjustment, your solution should be all set!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| res.setHeader( | ||
| 'Content-Disposition', | ||
| `attachment; filename=${file.originalFilename}.${compressionType}`, | ||
| ); |
There was a problem hiding this comment.
The filename extension for the compressed file does not fully match the requirements. According to the task description, the extension for gzip should be .gz and for deflate it should be .dfl. The current implementation uses the compressionType variable directly, which results in incorrect extensions like .gzip and .deflate.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
alexander-ignatow
left a comment
alexander-ignatow
left a comment
There was a problem hiding this comment.
Looks good!
The problem is that tests are not aligned with the task.
Accepting the current solution in order to move on
TODO: align tests with the tasks on Mate side
3 participants
No description provided.