Aligns tests with readme and adds simple solution to validate it works#226
Open
alexander-ignatow wants to merge 1 commit intomate-academy:masterfrom
Open
Aligns tests with readme and adds simple solution to validate it works#226alexander-ignatow wants to merge 1 commit intomate-academy:masterfrom
alexander-ignatow wants to merge 1 commit intomate-academy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR aligns the test with the readme and validates it with a simple solution
Summary of test changes:
The test data structure in createServer.test.js was updated so each compression type now has an explicit extension field:
gzip → gz
deflate → dfl
br → br
The Content-Disposition assertion was corrected to validate the README-defined file extension, not the compression type key itself.
This makes the header check strict and specification-driven (matching expected output filename format from the task description).
Why this was changed:
The README requires compressed files to use extensions .gz, .dfl, and .br.
Previously, tests inferred extension from compression type keys, which could pass even when implementation returned non-required suffixes.
The new assertions enforce exactly what the task asks for, reducing false positives.
Validation note:
The change was validated by creating a basic working implementation in createServer.js and running the suite.
With that implementation, tests pass and now correctly reflect README requirements, so tests and task specification are aligned.