Skip to content

last#4350

Open
doniliks wants to merge 13 commits intomate-academy:masterfrom
doniliks:master
Open

last#4350
doniliks wants to merge 13 commits intomate-academy:masterfrom
doniliks:master

Conversation

@doniliks
Copy link
Copy Markdown

@doniliks doniliks commented Apr 7, 2026

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving this submission as an educational override to support your learning journey—this helps you move forward while addressing key concepts incrementally. You've done an excellent job structuring the component folders (Article/, Header/, Navigation/, Welcome/) and correctly splitting global styles into App.css and component-specific styles like Article.css and Header.css [CHECKLIST ITEM #2]. However, two critical CSS files are missing: Navigation.css and Welcome.css—both are imported in their respective JSX files but weren’t included, which would break styling at runtime. Also, Navigation.jsx and Welcome.jsx were referenced in reviews but aren’t present in the submitted files, so please ensure all component files (JSX + CSS) are added together. These are great learning opportunities to reinforce the principle that each component folder should be self-contained with all its dependencies. Keep up the thoughtful decomposition—it’s a foundational React skill—and don’t hesitate to revisit how imports and file co-location work together. You're making strong progress!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment on lines 1 to +2
/* Put article styles here */

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import CSS file for styling

Comment on lines +2 to +3

.article {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import Navigation component

Comment on lines +4 to +5
margin: 5em auto 0;
padding: 1em;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment for Header function

Comment on lines +5 to +6
padding: 1em;
font-size: 140%;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment for Header function

Comment on lines +6 to +7
font-size: 140%;
max-width: 800px;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add default export for Header component

Comment on lines +7 to +8
max-width: 800px;
background: white;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define Header function

Comment on lines +8 to +9
background: white;
box-shadow: rgba(0, 0, 0, 0.05) 0 3px 15px;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return JSX for header element

Comment on lines +9 to +10
box-shadow: rgba(0, 0, 0, 0.05) 0 3px 15px;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open header div with className

Comment on lines +10 to +11
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add title with className

Comment on lines +11 to +12

.article__paragraph {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Render Navigation component

Comment on lines +12 to +13
.article__paragraph {
margin: 0;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close header div

Comment on lines +13 to +14
margin: 0;
color: #333;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close return statement

Comment on lines +14 to +15
color: #333;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close function definition

Comment on lines +16 to +17

.article__paragraph:not(:first-child) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Export default Header component

Comment thread src/App.jsx
import './App.css';
import Welcome from './components/Welcome/Welcome';
import Header from './components/Header/Header';
import Article from './components/Article/Article';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Navigation component is imported in Header.jsx but Navigation.jsx and Navigation.css files are not provided in the submission. The task explicitly states to create a folder for the Navigation component. Please add the Navigation component files.

Comment on lines 3 to 4
// Create an Article function returning the HTML of article block

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment explaining the purpose of this import.

Comment on lines 4 to 5

// Add a default export statement for Article component to use it in the other files
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary comments or ensure they are meaningful.

Comment on lines 5 to +6
// Add a default export statement for Article component to use it in the other files
import './Article.css';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a JSDoc comment for the Header component to improve documentation.

Comment on lines +6 to +7
import './Article.css';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the return statement is properly formatted and readable.

Comment on lines +7 to +8

function Article() {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a data-testid attribute for better testing capabilities.

Comment on lines +8 to +9
function Article() {
return (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the Navigation component is properly implemented and tested.

Comment on lines +9 to +10
return (
<article className="article">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the closing tag for header is correctly placed.

Comment on lines +10 to +11
<article className="article">
<h2 className="article__title">Headline</h2>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the closing tag for function is correctly placed.

Comment on lines +11 to +12
<h2 className="article__title">Headline</h2>
<p className="article__paragraph">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the export statement is correctly formatted.

Comment on lines +13 to +14
In elementum lorem eget est euismod ornare. Phasellus sit amet
pellentesque mauris. Aliquam quis malesuada ex. Nullam eu aliquam nibh.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the export statement is correctly formatted.

@@ -0,0 +1,19 @@
import './Navigation.css';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation.jsx imports Navigation.css but this CSS file is not provided in the submission. The task requires splitting CSS code along with component decomposition.

@@ -0,0 +1,19 @@
import './Navigation.css';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome.jsx imports Welcome.css but this CSS file is not provided in the submission. The task requires splitting CSS code along with component decomposition.

@@ -3,3 +3,16 @@
// Create a Header function returning the HTML of header block

// Add a default export statement for Header component to use it in the other files
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation.css is missing but Navigation.jsx references '.navigation' and '.navigation__link' classes. The CSS file must be created with these styles for the component to work properly.

import Navigation from '../Navigation/Navigation';

function Header() {
return (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome.css is missing but Welcome.jsx references '.welcome' and '.welcome__text' classes. The CSS file must be created with these styles for the component to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants