Skip to content

Develop#4192

Open
Teti-web wants to merge 2 commits intomate-academy:masterfrom
Teti-web:develop
Open

Develop#4192
Teti-web wants to merge 2 commits intomate-academy:masterfrom
Teti-web:develop

Conversation

@Teti-web
Copy link
Copy Markdown

No description provided.

@Teti-web Teti-web changed the base branch from develop to master April 11, 2026 06:44
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because one explicit checklist requirement about JSX string interpolation is still not satisfied, even though your Sum component works correctly.
In src/components/Sum/Sum.jsx, in the return of the Sum component around the <p> element, you currently render Sum of {a} and {b} is {a + b}, which violates [CHECKLIST ITEM #2] – Use string interpolation inside tag content that requires a single template literal expression instead of mixing plain text with multiple JSX expressions.
To fix this, change that line to use one template literal inside the tag content, for example:

<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>

and make sure any duplicated paragraph (such as in App.jsx or tests/docs if present) follows the same pattern.
Once you align this paragraph with the required style, your implementation will fully match the checklist and will be in great shape.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/App.jsx
Comment on lines 1 to 2
import React from 'react';
import './App.scss';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: "2. [CODE STYLE] - Use string interpolation inside tag content"

The Sum component renders the paragraph as <p>Sum of {a} and {b} is {a + b}</p>, which matches the BAD example (multiple JSX text/expression segments). Please use a single template literal inside the tag content instead, for example:

<p>{Sum of ${a} and ${b} is ${a + b}}</p>

This keeps the same output but matches the required code style.

Comment thread src/components/Sum/Sum.jsx Outdated
@@ -1 +1,3 @@
// export const Sum = () => ();
export const Sum = ({ a = 0, b = 0 }) => {
return <p>Sum of {a} and {b} is {a + b}</p>;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: "2. [CODE STYLE] - Use string interpolation inside tag content"

The Sum component renders the paragraph as <p>Sum of {a} and {b} is {a + b}</p>. According to the checklist you should use a template literal inside the tag content. Consider changing it to:

<p>{Sum of ${a} and ${b} is ${a + b}}</p>

so the component matches the required code style.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved because it correctly implements all the required behavior for the Sum component and its usage in App.jsx. The Sum component is a named export with default values a = 0 and b = 0, and it renders the exact required sentence using a single template literal inside the <p> tag, which matches the checklist requirement for interpolation [CHECKLIST ITEM #2]. In App.jsx, you render Sum in all five required configurations (both props, negative and positive values, only a, only b, and with no props), so all specified input cases are covered and work with the defaults. Your JSX also follows the style guideline of keeping short component usages on one line, aligning with the formatting checklist [CHECKLIST ITEM #1]. As minor next steps, I recommend running npm test locally to confirm all tests pass and adding your deployed demo link (with your GitHub username in place of <your_account>) to the PR description for easier manual verification. Overall, this is a clean and complete implementation that demonstrates good attention to both functionality and the task checklist.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants