Skip to content

Develop#4199

Open
MN1rvana wants to merge 3 commits intomate-academy:masterfrom
MN1rvana:develop
Open

Develop#4199
MN1rvana wants to merge 3 commits intomate-academy:masterfrom
MN1rvana:develop

Conversation

@MN1rvana
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Changes are needed because, although your Sum component and App usage are functionally correct, one explicit checklist code-style requirement is not satisfied. In both src/App.jsx and src/components/Sum/Sum.jsx, the <p> line that currently renders as Sum of {a} and {b} is {a + b} violates [CHECKLIST ITEM #2] Use string interpolation inside tag content. The requirement is that the entire text inside the <p> be produced by a single template literal expression, for example:

<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>

Please update the <p> in both files to follow this pattern (one template literal inside the JSX expression, no separate text and {} chunks). Functionality, default props, and the required Sum usages in App all look good, so once you align the paragraph content with the interpolation style requirement, your solution will fully meet the task and checklist expectations. This is a small, stylistic fix, but it’s important to practice following the specified style rules exactly.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/App.jsx
Comment thread src/components/Sum/Sum.jsx Outdated
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved because it correctly implements all the required functionality for the Sum component and its usage in App. The Sum component is a named export, uses destructured default props a = 0 and b = 0, and renders the exact required sentence using a single template literal inside a <p> tag. In src/App.jsx, you demonstrate all five required usages of Sum (with (2, 3), (-5, 5), (10), {b: 5}, and with no props), and your short JSX tags with fewer than three attributes are kept on a single line, matching the style checklist. There are no critical or blocking issues with correctness or requirements compliance. As minor, non-blocking suggestions, make sure Prettier or your editor formatting is enabled and run npm test to confirm the test suite passes, as expected by the task. Overall, this is a clear and clean implementation that satisfies the task requirements well.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants