Skip to content

ToDo App task#1286

Open
devTym wants to merge 2 commits intomate-academy:masterfrom
devTym:develop
Open

ToDo App task#1286
devTym wants to merge 2 commits intomate-academy:masterfrom
devTym:develop

Conversation

@devTym
Copy link
Copy Markdown

@devTym devTym commented Mar 15, 2026

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, but there should be an error when I try to submit an empty todo

@devTym
Copy link
Copy Markdown
Author

devTym commented Mar 16, 2026

I couldn't find this requirement in the task description or in the TODO app example.
In the demo app submitting an empty todo is simply ignored and no error is shown.

Do you want me to add an error for empty todos anyway?

@devTym devTym requested a review from brespect March 16, 2026 09:17
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, its better to improve the UX, lets implement this

@devTym devTym requested a review from brespect March 16, 2026 13:30
Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

If you're planning to add this project into your Portfolio, please make ErrorNotification disappearing after 3000 ms (see Todo App with API project to simply copy-paste this logic into this one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants