-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add solution #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0-nira-0
wants to merge
3
commits into
mate-academy:master
Choose a base branch
from
0-nira-0:dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add solution #1290
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,157 +1,12 @@ | ||
| /* eslint-disable jsx-a11y/control-has-associated-label */ | ||
| import React from 'react'; | ||
| import { TodosContextProvider } from './components/TodosProvider'; | ||
| import { TodoApp } from './components/TodoApp'; | ||
| import './styles/index.scss'; | ||
|
|
||
| export const App: React.FC = () => { | ||
| return ( | ||
| <div className="todoapp"> | ||
| <h1 className="todoapp__title">todos</h1> | ||
|
|
||
| <div className="todoapp__content"> | ||
| <header className="todoapp__header"> | ||
| {/* this button should have `active` class only if all todos are completed */} | ||
| <button | ||
| type="button" | ||
| className="todoapp__toggle-all active" | ||
| data-cy="ToggleAllButton" | ||
| /> | ||
|
|
||
| {/* Add a todo on form submit */} | ||
| <form> | ||
| <input | ||
| data-cy="NewTodoField" | ||
| type="text" | ||
| className="todoapp__new-todo" | ||
| placeholder="What needs to be done?" | ||
| /> | ||
| </form> | ||
| </header> | ||
|
|
||
| <section className="todoapp__main" data-cy="TodoList"> | ||
| {/* This is a completed todo */} | ||
| <div data-cy="Todo" className="todo completed"> | ||
| <label className="todo__status-label"> | ||
| <input | ||
| data-cy="TodoStatus" | ||
| type="checkbox" | ||
| className="todo__status" | ||
| checked | ||
| /> | ||
| </label> | ||
|
|
||
| <span data-cy="TodoTitle" className="todo__title"> | ||
| Completed Todo | ||
| </span> | ||
|
|
||
| {/* Remove button appears only on hover */} | ||
| <button type="button" className="todo__remove" data-cy="TodoDelete"> | ||
| × | ||
| </button> | ||
| </div> | ||
|
|
||
| {/* This todo is an active todo */} | ||
| <div data-cy="Todo" className="todo"> | ||
| <label className="todo__status-label"> | ||
| <input | ||
| data-cy="TodoStatus" | ||
| type="checkbox" | ||
| className="todo__status" | ||
| /> | ||
| </label> | ||
|
|
||
| <span data-cy="TodoTitle" className="todo__title"> | ||
| Not Completed Todo | ||
| </span> | ||
|
|
||
| <button type="button" className="todo__remove" data-cy="TodoDelete"> | ||
| × | ||
| </button> | ||
| </div> | ||
|
|
||
| {/* This todo is being edited */} | ||
| <div data-cy="Todo" className="todo"> | ||
| <label className="todo__status-label"> | ||
| <input | ||
| data-cy="TodoStatus" | ||
| type="checkbox" | ||
| className="todo__status" | ||
| /> | ||
| </label> | ||
|
|
||
| {/* This form is shown instead of the title and remove button */} | ||
| <form> | ||
| <input | ||
| data-cy="TodoTitleField" | ||
| type="text" | ||
| className="todo__title-field" | ||
| placeholder="Empty todo will be deleted" | ||
| value="Todo is being edited now" | ||
| /> | ||
| </form> | ||
| </div> | ||
|
|
||
| {/* This todo is in loadind state */} | ||
| <div data-cy="Todo" className="todo"> | ||
| <label className="todo__status-label"> | ||
| <input | ||
| data-cy="TodoStatus" | ||
| type="checkbox" | ||
| className="todo__status" | ||
| /> | ||
| </label> | ||
|
|
||
| <span data-cy="TodoTitle" className="todo__title"> | ||
| Todo is being saved now | ||
| </span> | ||
|
|
||
| <button type="button" className="todo__remove" data-cy="TodoDelete"> | ||
| × | ||
| </button> | ||
| </div> | ||
| </section> | ||
|
|
||
| {/* Hide the footer if there are no todos */} | ||
| <footer className="todoapp__footer" data-cy="Footer"> | ||
| <span className="todo-count" data-cy="TodosCounter"> | ||
| 3 items left | ||
| </span> | ||
|
|
||
| {/* Active link should have the 'selected' class */} | ||
| <nav className="filter" data-cy="Filter"> | ||
| <a | ||
| href="#/" | ||
| className="filter__link selected" | ||
| data-cy="FilterLinkAll" | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| className="filter__link" | ||
| data-cy="FilterLinkActive" | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| className="filter__link" | ||
| data-cy="FilterLinkCompleted" | ||
| > | ||
| Completed | ||
| </a> | ||
| </nav> | ||
|
|
||
| {/* this button should be disabled if there are no completed todos */} | ||
| <button | ||
| type="button" | ||
| className="todoapp__clear-completed" | ||
| data-cy="ClearCompletedButton" | ||
| > | ||
| Clear completed | ||
| </button> | ||
| </footer> | ||
| </div> | ||
| </div> | ||
| <TodosContextProvider> | ||
| <TodoApp /> | ||
| </TodosContextProvider> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| // crud operations with localstorage for todos | ||
|
|
||
| import { Todo } from '../components/TodosProvider'; | ||
|
|
||
| const TODOS_STORAGE_NAME = 'todos'; | ||
|
|
||
| function saveTodosToStorage(todos: Todo[]) { | ||
| if (todos.length === 0) { | ||
| localStorage.setItem(TODOS_STORAGE_NAME, '[]'); | ||
| } else { | ||
| localStorage.setItem(TODOS_STORAGE_NAME, JSON.stringify(todos)); | ||
| } | ||
| } | ||
|
|
||
| export function getTodosFromStorage(): Todo[] { | ||
| const todosFromStorage = localStorage.getItem(TODOS_STORAGE_NAME); | ||
|
|
||
| if (!todosFromStorage) { | ||
| localStorage.setItem(TODOS_STORAGE_NAME, '[]'); | ||
| } | ||
|
|
||
| return todosFromStorage ? JSON.parse(todosFromStorage) : []; | ||
| } | ||
|
|
||
| export function setTodosInStorage(todos: Todo[]) { | ||
| saveTodosToStorage(todos); | ||
| } | ||
|
|
||
| export function addTodoToStorage(todo: Todo) { | ||
| const todosFromStorage = getTodosFromStorage(); | ||
|
|
||
| todosFromStorage.push(todo); | ||
|
|
||
| saveTodosToStorage(todosFromStorage); | ||
|
|
||
| return todo; | ||
| } | ||
|
|
||
| export function deleteTodoFromStorage(todoId: Todo['id']) { | ||
| const todosFromStorage = getTodosFromStorage(); | ||
|
|
||
| const filteredTodosList = todosFromStorage.filter(todo => todo.id !== todoId); | ||
|
|
||
| saveTodosToStorage(filteredTodosList); | ||
| } | ||
|
|
||
| export function updateTodoInStorage( | ||
| todoId: Todo['id'], | ||
| payload: Partial<Omit<Todo, 'id'>>, | ||
| ) { | ||
| const todosFromStorage = getTodosFromStorage(); | ||
|
|
||
| const updatedTodosList = todosFromStorage.map(todo => { | ||
| if (todo.id === todoId) { | ||
| return { ...todo, ...payload }; | ||
| } | ||
|
|
||
| return todo; | ||
| }); | ||
|
|
||
| saveTodosToStorage(updatedTodosList); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { useContext } from 'react'; | ||
| import { TodoFooter } from './TodoFooter'; | ||
| import { TodoHeader } from './TodoHeader'; | ||
| import { TodoList } from './TodoList'; | ||
| import { TodosContext } from './TodosProvider'; | ||
| import '../styles/todoapp.scss'; | ||
|
|
||
| export const TodoApp = () => { | ||
| const { todos } = useContext(TodosContext); | ||
|
|
||
| return ( | ||
| <div className="todoapp"> | ||
| <h1 className="todoapp__title">todos</h1> | ||
|
|
||
| <div className="todoapp__content"> | ||
| <TodoHeader /> | ||
|
|
||
| <TodoList /> | ||
|
|
||
| {todos.length !== 0 && <TodoFooter />} | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import { useContext } from 'react'; | ||
| import '../styles/filters.scss'; | ||
| import { TodoFilterStatus, TodosContext } from './TodosProvider'; | ||
| import classNames from 'classnames'; | ||
| import { checkSomeTodosCompleted } from '../utils'; | ||
|
|
||
| export const TodoFooter = () => { | ||
| const { todos, setTodoFilterStatus, todoFilterStatus, deleteTodo } = | ||
| useContext(TodosContext); | ||
|
|
||
| function handleClearAllCompletedTodos() { | ||
| todos.forEach(todo => { | ||
| if (todo.completed) { | ||
| deleteTodo(todo.id); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| return ( | ||
| <footer className="todoapp__footer" data-cy="Footer"> | ||
| <span className="todo-count" data-cy="TodosCounter"> | ||
| {todos.filter(todo => !todo.completed).length} items left | ||
| </span> | ||
| <nav className="filter" data-cy="Filter"> | ||
| {[ | ||
| TodoFilterStatus.All, | ||
| TodoFilterStatus.Active, | ||
| TodoFilterStatus.Completed, | ||
| ].map(filterName => ( | ||
| <a | ||
| key={filterName} | ||
| href="#/" | ||
| className={classNames('filter__link', { | ||
| selected: filterName === todoFilterStatus, | ||
| })} | ||
| onClick={() => setTodoFilterStatus(filterName)} | ||
| data-cy={`FilterLink${filterName}`} | ||
| > | ||
| {filterName} | ||
| </a> | ||
| ))} | ||
| </nav> | ||
| <button | ||
| type="button" | ||
| className="todoapp__clear-completed" | ||
| data-cy="ClearCompletedButton" | ||
| disabled={!checkSomeTodosCompleted(todos)} | ||
| onClick={handleClearAllCompletedTodos} | ||
| > | ||
| Clear completed | ||
| </button> | ||
| </footer> | ||
| ); | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.