refactor: eliminate all 132 circular dependency cycles in cattool JS bundle by riccio82 · Pull Request #4530 · matecat/MateCat

riccio82 · 2026-04-24T14:38:34Z

Summary

Eliminates all 132 circular dependency cycles detected by madge in the cattool JS bundle, bringing the count to 0. Adds a zero-tolerance checker (yarn check:circular-deps) to prevent regressions.

Motivation

Circular dependencies cause subtle bugs (modules evaluating to undefined at import time), make the dependency graph harder to reason about, and block future migration to Vite/ESM which enforces stricter module resolution.

Approach

Four complementary techniques, applied in order of decreasing structural impact:

1. Modal Registry Pattern (132 → 81 cycles)

Actions were importing React components just to pass them to ModalsActions.showModalComponent(). Replaced with a string-key registry — actions register component names, the modal root resolves them at render time. Zero runtime behaviour change.

2. Sibling File Extractions (81 → 25 cycles)

Extracted constants, contexts, and utilities that were defined inside parent components but imported by children, creating parent→child→parent cycles:

SettingsPanel → 13 new sibling files (contexts, utils, constants)
DraftMatecatUtils/tagUtils → htmlUtils.js
SegmentConstants → SegmentTabConstants.js

3. Lazy-Require Pattern (25 → 0 cycles)

For bilateral hub cycles (e.g., SegmentActions ↔ SegmentStore) where structural extraction wasn't practical, replaced static import with deferred require() at the call site:

// Before: import at module evaluation time (creates cycle)
import OfflineUtils from '../utils/offlineUtils'

// After: resolve at call time (breaks cycle for static analysis)
let _OfflineUtils
const getOfflineUtils = () =>
  _OfflineUtils || (_OfflineUtils = require('../utils/offlineUtils').default)

Every lazy-require block has a comment explaining why require() is used. madge (and future Vite) only traces static import — the cycle is broken for tooling while webpack still resolves the module correctly at runtime.

4. CI Guard

check-circular-deps.js — runs madge --circular and fails if any cycle is found. Invoked via yarn check:circular-deps. Zero-tolerance: no baseline file, no ratchet — any cycle is a failure.

Files Changed

Area	Key Files
CI guard	`check-circular-deps.js`, `package.json` (madge devDep + script)
Modal registry	`public/js/actions/*.js`, `public/js/components/modals/ModalContainer.js`
Sibling extractions	`public/js/components/settingsPanel/*.js` (13 new), `public/js/constants/SegmentTabConstants.js`
htmlUtils extraction	`public/js/components/segments/utils/DraftMatecatUtils/htmlUtils.js` (new)
Lazy-require hubs	`SegmentActions.js`, `CatToolActions.js`, `SegmentStore.js`, `commonUtils.js`, `offlineUtils.js`
Bug fix	`SegmentFooter.js` — TAB constant import was broken by re-export; fixed to direct import

Verification

✅ node check-circular-deps.js → 0 cycles (was 132)
✅ webpack 5.104.1 compiled successfully — verified after every phase
✅ Plugin folders (airbnb, uber, translated) checked — zero import impact across all phases

Notes

The lazy-require pattern uses CommonJS require() inside ESM files — this works under webpack but will need conversion when migrating to Vite. Each site is commented for easy discovery.
No plugin code was modified. All changes are in the public repo.

Add madge devDependency with a 132-cycle baseline snapshot and a check script that fails on regressions and reports new cycles introduced. Run: yarn check:circular-deps Update baseline after fixes: node check-circular-deps.js --update-baseline

…ring keys Introduce a modal registry pattern to break 51 circular dependency cycles (132→81). Actions now dispatch string keys instead of component references; ModalWindow resolves them via the registry at render time. - Extract TAB, ONBOARDING_STEP, COPY_SOURCE_COOKIE constants to dedicated files - Create ModalKeys constants and modalRegistry for component resolution - Update ModalsActions, CatToolActions, SegmentActions to use string keys - Backward compatible: components can still pass refs directly

…ibling files Break parent→child circular dependencies across 13 settingsPanel component families by extracting shared symbols (contexts, utility functions, constants) into dedicated sibling files. Children now import from leaf modules instead of their parent components. 81 → 40 circular dependency cycles (51% reduction, 70% total from 132).

…bilateral cycles Break 15 circular dependency cycles (40→25) via: - OnBoarding: extract context/socialUrls to OnBoardingContext.js (5 cycles) - ActivityLog: extract context/constants to sibling files (3 cycles) - SegmentFooterTabGlossary: extract icons/constants to GlossaryConstants.js (2 cycles) - UploadFile: extract getPrintableFileSize to UploadFileUtils.js (2 cycles) - SettingsPanel: move DEFAULT_ENGINE_MEMORY to SettingsPanelConstants.js (1 cycle) - DraftMatecatUtils: extract regexWordDelimiter to textConstants.js (3 cycles) Cumulative: 132→25 (81% reduction). Plugins verified clean.

…bilateral cycle Move getIdAttributeRegEx, unescapeHTMLinTags, and unescapeHTMLRecursive into a new htmlUtils.js file to eliminate the tagUtils → textUtils → tagUtils cycle. tagUtils re-exports for backward compatibility. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

Replace static imports of CatToolActions, segment_filter, translationMatches, DraftMatecatUtils, setTranslationUtil, OfflineUtils, and SegmentUtils with lazy-require getters. Updates 58+ call sites. These modules form the hub of most remaining circular dependency cycles. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

…tils, and offlineUtils SegmentStore: lazy-require DraftMatecatUtils (8 sites). commonUtils: lazy-require OfflineUtils, SegmentActions, SegmentStore, setTranslationUtil (5 sites). offlineUtils: lazy-require setTranslationUtil (1 site). Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

…cycle Breaks the last remaining bilateral (CatToolActions <-> offlineUtils). Circular dependency count: 132 -> 0. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

- replace ratchet-based baseline comparison with zero-tolerance check - delete .madge-baseline.json as baseline tracking is no longer needed - script now fails if any circular dependency exists and prints all cycles

- replace dead re-export with direct import so TAB is bound in module scope

Copilot

Pull request overview

Refactors the cattool frontend bundle to eliminate circular dependency cycles (as detected by madge), and adds a CI-style guard script to prevent regressions. This is achieved via a modal key registry, extraction of constants/contexts/utilities into sibling modules, and targeted lazy require() usage at call sites.

Changes:

Add check-circular-deps.js + yarn check:circular-deps and include madge as a dev dependency.
Introduce modal key registry (MODAL_KEY + resolveModal) and update actions to reference modals by key instead of importing components.
Break remaining cycles by extracting shared constants/contexts/utils and replacing selected static imports with lazy require().

Reviewed changes

Copilot reviewed 103 out of 104 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
yarn.lock	Adds/updates lock entries for new circular-deps tooling dependencies (madge + transitive deps).
public/js/utils/textUtils.js	Updates `regexWordDelimiter` import to point to extracted constants module.
public/js/utils/offlineUtils.js	Replaces static import with lazy `require()` to break setTranslationUtil cycle.
public/js/utils/commonUtils.js	Converts several static imports to lazy `require()` getters to break cycles.
public/js/stores/SegmentStore.js	Lazy-loads DraftMatecatUtils/SegmentUtils to break circular dependencies.
public/js/pages/ActivityLog.js	Moves ActivityLog context to a dedicated module and re-exports it.
public/js/constants/SegmentTabConstants.js	New shared TAB constants extracted from SegmentFooter.
public/js/constants/OnBoardingConstants.js	New shared onboarding step constants extracted from OnBoarding.
public/js/constants/ModalKeys.js	New modal key constants + shared cookie constant for modal registry pattern.
public/js/components/xliffToTarget/UploadXliff.js	Updates imports to extracted glossary constants and upload file size util.
public/js/components/settingsPanel/Tab.js	Switches to extracted SettingsPanel constants module.
public/js/components/settingsPanel/SettingsPanelTable/SettingsPanelTableContext.js	New extracted context to avoid parent/child import cycles.
public/js/components/settingsPanel/SettingsPanelTable/SettingsPanelTable.js	Uses extracted SPECIAL_ROWS_ID + extracted table context.
public/js/components/settingsPanel/SettingsPanelTable/SettingsPanelRow.js	Updates context import to extracted context module.
public/js/components/settingsPanel/SettingsPanelConstants.js	New extracted settings panel constants and default engine metadata.
public/js/components/settingsPanel/SettingsPanel.js	Uses extracted DEFAULT_ENGINE_MEMORY (re-exported for compatibility).
public/js/components/settingsPanel/ProjectTemplate/TemplateNameInput.js	Switches TEMPLATE_MODIFIERS import to extracted constants.
public/js/components/settingsPanel/ProjectTemplate/ProjectTemplateConstants.js	New extracted template modifier constants.
public/js/components/settingsPanel/ProjectTemplate/ProjectTemplate.js	Uses extracted TEMPLATE_MODIFIERS (re-exported for compatibility).
public/js/components/settingsPanel/ProjectTemplate/MoreMenu.js	Switches TEMPLATE_MODIFIERS import to extracted constants.
public/js/components/settingsPanel/ProjectTemplate/CreateUpdateControl.js	Switches TEMPLATE_MODIFIERS import to extracted constants.
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TranslationMemoryGlossaryTabUtils.js	New extracted TM glossary tab utilities/constants.
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TranslationMemoryGlossaryTabContext.js	New extracted context to avoid cycles.
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TMKeyRow.js	Updates imports to extracted context + utils module.
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TMCreateResourceRow.js	Updates imports to extracted context + utils module.
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateSelect.js	Uses extracted SubTemplates context module.
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateNameInput.js	Uses extracted SubTemplates context module.
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateMoreMenu.js	Uses extracted SubTemplates context module.
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateCreateUpdateControl.js	Uses extracted SubTemplates context module.
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateContext.js	New extracted SubTemplates modifiers/helpers/context.
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplate.js	Imports/re-exports from extracted SubTemplateContext.
public/js/components/settingsPanel/Contents/QualityFrameworkTab/SeverityRow.js	Uses extracted QualityFramework tab context module.
public/js/components/settingsPanel/Contents/QualityFrameworkTab/SeverityColumn.js	Uses extracted QualityFramework tab context module.
public/js/components/settingsPanel/Contents/QualityFrameworkTab/QualityFrameworkTabContext.js	New extracted context to avoid cycles.
public/js/components/settingsPanel/Contents/QualityFrameworkTab/QualityFrameworkTab.js	Uses extracted QualityFramework tab context (re-exported).
public/js/components/settingsPanel/Contents/QualityFrameworkTab/ModifySeverity.js	Uses extracted context + extracted Categories/Severities utils.
public/js/components/settingsPanel/Contents/QualityFrameworkTab/ModifyCategory.js	Uses extracted context + extracted Categories/Severities utils.
public/js/components/settingsPanel/Contents/QualityFrameworkTab/EptThreshold.js	Uses extracted QualityFramework tab context module.
public/js/components/settingsPanel/Contents/QualityFrameworkTab/CategoryRow.js	Uses extracted context + extracted Categories/Severities utils.
public/js/components/settingsPanel/Contents/QualityFrameworkTab/CategoriesSeveritiesTableUtils.js	New extracted helper functions from CategoriesSeveritiesTable.
public/js/components/settingsPanel/Contents/QualityFrameworkTab/CategoriesSeveritiesTable.js	Re-exports helpers from extracted utils and uses extracted context.
public/js/components/settingsPanel/Contents/QualityFrameworkTab/AddSeverityCell.js	Uses extracted QualityFramework tab context module.
public/js/components/settingsPanel/Contents/QualityFrameworkTab/AddSeverity.js	Uses extracted context + extracted helper util.
public/js/components/settingsPanel/Contents/QualityFrameworkTab/AddCategory.js	Uses extracted context + extracted helper utils.
public/js/components/settingsPanel/Contents/MachineTranslationTab/MachineTranslationTab.js	Updates DEFAULT_ENGINE_MEMORY import to extracted constants file.
public/js/components/settingsPanel/Contents/MachineTranslationTab/MTGlossary/MTGlossaryRow.js	Switches MT glossary status import to extracted constants.
public/js/components/settingsPanel/Contents/MachineTranslationTab/MTGlossary/MTGlossaryCreateRow.js	Switches MT glossary status/constants import to extracted constants.
public/js/components/settingsPanel/Contents/MachineTranslationTab/MTGlossary/MTGlossaryConstants.js	New extracted MT glossary status class/constants.
public/js/components/settingsPanel/Contents/MachineTranslationTab/DeepLGlossary/DeepLGlossaryCreateRow.js	Switches constants import to extracted DeepL constants file.
public/js/components/settingsPanel/Contents/MachineTranslationTab/DeepLGlossary/DeepLGlossaryConstants.js	New extracted DeepL glossary constants.
public/js/components/settingsPanel/Contents/MachineTranslationTab/DeepLGlossary/DeepLGlossary.js	Uses extracted DeepL glossary constants (re-exported).
public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/XliffSettingsContext.js	New extracted XliffSettings context.
public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/XliffSettings.js	Uses extracted XliffSettings context (re-exported).
public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/Xliff20.js	Updates context import to extracted context module.
public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/Xliff12.js	Updates context import to extracted context module.
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Yaml.js	Updates context import to extracted FiltersParamsContext.
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Xml.js	Updates context import to extracted FiltersParamsContext.
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/MsWord.js	Updates context import to extracted FiltersParamsContext.
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/MsPowerpoint.js	Updates context import to extracted FiltersParamsContext.
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/MsExcel.js	Updates context import to extracted FiltersParamsContext.
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Json.js	Updates context import to extracted FiltersParamsContext.
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/FiltersParamsContext.js	New extracted FiltersParams context.
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/FiltersParams.js	Uses extracted FiltersParams context (re-exported).
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Dita.js	Updates context import to extracted FiltersParamsContext.
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/AccordionGroupFiltersParams.js	Updates context import to extracted FiltersParamsContext.
public/js/components/settingsPanel/Contents/AnalysisTab/BreakdownsTable.js	Switches breakdown constants import to extracted module.
public/js/components/settingsPanel/Contents/AnalysisTab/AnalysisTabConstants.js	New extracted analysis breakdown constants.
public/js/components/settingsPanel/Contents/AnalysisTab/AnalysisTab.js	Uses extracted breakdown constants (re-exported).
public/js/components/segments/utils/DraftMatecatUtils/textUtils.js	Moves regex delimiter to extracted constants module (re-exported).
public/js/components/segments/utils/DraftMatecatUtils/textConstants.js	New extracted regex constants for word delimiter logic.
public/js/components/segments/utils/DraftMatecatUtils/tagUtils.js	Extracts HTML utility helpers into `htmlUtils.js` to avoid cycles.
public/js/components/segments/utils/DraftMatecatUtils/htmlUtils.js	New extracted HTML unescape/id-regex helpers.
public/js/components/segments/utils/DraftMatecatUtils/decodeTagInfo.js	Updates imports to use extracted html utils.
public/js/components/segments/SegmentSource.js	Switches glossary constants import to extracted GlossaryConstants.
public/js/components/segments/SegmentFooterTabGlossary/TermForm.js	Switches TERM_FORM_FIELDS import to extracted GlossaryConstants.
public/js/components/segments/SegmentFooterTabGlossary/SegmentFooterTabGlossary.js	Extracts glossary constants/icons into dedicated module and re-exports.
public/js/components/segments/SegmentFooterTabGlossary/GlossaryItem.js	Switches icons import to extracted GlossaryConstants.
public/js/components/segments/SegmentFooterTabGlossary/GlossaryConstants.js	New extracted glossary constants + icon components.
public/js/components/segments/SegmentFooter.js	Switches TAB constants import to new `SegmentTabConstants`.
public/js/components/onBoarding/SocialButtons.js	Uses extracted OnBoardingContext module.
public/js/components/onBoarding/Register.js	Uses extracted onboarding step constants + OnBoardingContext module.
public/js/components/onBoarding/PasswordReset.js	Uses extracted onboarding step constants + OnBoardingContext module.
public/js/components/onBoarding/OnBoardingContext.js	New extracted onboarding context + social URL config.
public/js/components/onBoarding/OnBoarding.js	Uses extracted constants/context and re-exports for compatibility.
public/js/components/onBoarding/Login.js	Uses extracted onboarding step constants + OnBoardingContext module.
public/js/components/onBoarding/ForgotPassword.js	Uses extracted onboarding step constants + OnBoardingContext module.
public/js/components/modals/modalRegistry.js	New modal registry that maps MODAL_KEY strings to modal components.
public/js/components/modals/ModalWindow.js	Resolves modal keys to components at render time via modal registry.
public/js/components/modals/CopySourceModal.js	Moves cookie constant to shared ModalKeys (re-exported).
public/js/components/createProject/UploadGdrive.js	Switches to extracted `getPrintableFileSize` + glossary constants import.
public/js/components/createProject/UploadFileUtils.js	New extracted file-size formatting utility.
public/js/components/createProject/UploadFileLocal.js	Switches to extracted `getPrintableFileSize` + glossary constants import.
public/js/components/createProject/UploadFile.js	Uses extracted `getPrintableFileSize` (re-exported for compatibility).
public/js/components/activityLog/FilterColumn.js	Uses extracted ActivityLog context and constants modules.
public/js/components/activityLog/ColumnSorting.js	Uses extracted ActivityLog context module.
public/js/components/activityLog/ActivityLogTable.js	Extracts column constants and uses extracted ActivityLog context.
public/js/components/activityLog/ActivityLogContext.js	New extracted ActivityLog context module.
public/js/components/activityLog/ActivityLogConstants.js	New extracted ActivityLog table column definitions.
public/js/actions/SegmentActions.js	Removes modal component imports in favor of modal keys + adds lazy-require hubs.
public/js/actions/ModalsActions.js	Opens modals via MODAL_KEY (no direct component imports).
public/js/actions/CatToolActions.js	Switches modal usage to MODAL_KEY and lazy-loads OfflineUtils.
public/img/icons/ChangePassword.js	Fixes React SVG attribute casing (`clipPath`).
package.json	Adds `madge` devDependency and `check:circular-deps` script.
check-circular-deps.js	New script that fails CI when madge detects circular dependencies.

Copilot · 2026-04-24T14:43:13Z

          SEGMENTS_STATUS.APPROVED,
        )
-        setTimeout(CatToolActions.updateFooterStatistics(), 2000)
+        setTimeout(getCatToolActions().updateFooterStatistics(), 2000)


setTimeout(getCatToolActions().updateFooterStatistics(), 2000) calls updateFooterStatistics() immediately and passes its return value to setTimeout, so the delay never applies. Wrap the call in a function (or pass a function reference) so it runs after 2s.

Copilot · 2026-04-24T14:43:14Z

          SEGMENTS_STATUS.TRANSLATED,
        )
-        setTimeout(CatToolActions.updateFooterStatistics(), 2000)
+        setTimeout(getCatToolActions().updateFooterStatistics(), 2000)


Same setTimeout issue here: setTimeout(getCatToolActions().updateFooterStatistics(), 2000) executes immediately instead of after 2 seconds. Pass a callback to setTimeout so the stats refresh is actually delayed.

Copilot · 2026-04-24T14:43:14Z

+const {execSync} = require('child_process')
+
+let cycles
+try {
+  const output = execSync(
+    'npx madge --circular --extensions js --json public/js/',


This script invokes madge via npx. Since madge is already a devDependency, calling the local binary (e.g., ./node_modules/.bin/madge or resolving it programmatically) avoids any reliance on npx/npm being available and prevents accidental network fetches in constrained CI environments.

Suggested change

const {execSync} = require('child_process')

let cycles

try {

const output = execSync(

'npx madge --circular --extensions js --json public/js/',

const {execFileSync} = require('child_process')

let cycles

try {

const output = execFileSync(

process.execPath,

[

require.resolve('madge/bin/cli.js'),

'--circular',

'--extensions',

'js',

'--json',

'public/js/',

],

- Replace local createContext in TranslationMemoryGlossaryTab with import from extracted TranslationMemoryGlossaryTabContext module to ensure parent and children share the same context object - Fix QualityFrameworkTab test waitFor assertions that compared array to number (always true), making them actually wait for async API data to load - Add explicit ApplicationWrapperContext import to QualityFrameworkTab test to initialize window.eventHandler, previously loaded as side effect through ModalsActions transitive import chain - Remove dead re-exports of extracted context objects from both QualityFrameworkTab and TranslationMemoryGlossaryTab - Remove unused createContext imports

riccio82 and others added 11 commits April 24, 2026 14:03

chore: update circular dependency baseline to 0 cycles

b666d37

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

🔧 chore: simplify circular dependency checker and remove baseline

135b467

- replace ratchet-based baseline comparison with zero-tolerance check - delete .madge-baseline.json as baseline tracking is no longer needed - script now fails if any circular dependency exists and prints all cycles

🐛 fix(cattool): import TAB constant in SegmentFooter

1c58157

- replace dead re-export with direct import so TAB is bound in module scope

Copilot AI review requested due to automatic review settings April 24, 2026 14:38

riccio82 had a problem deploying to ci_test April 24, 2026 14:38 — with GitHub Actions Failure

Copilot started reviewing on behalf of riccio82 April 24, 2026 14:39 View session

riccio82 added the In Progress label Apr 24, 2026

github-advanced-security AI found potential problems Apr 24, 2026

View reviewed changes

Comment thread public/js/components/segments/utils/DraftMatecatUtils/htmlUtils.js Dismissed

Comment thread public/js/components/segments/utils/DraftMatecatUtils/htmlUtils.js Dismissed

Copilot AI reviewed Apr 24, 2026

View reviewed changes

riccio82 temporarily deployed to ci_test April 24, 2026 15:58 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: eliminate all 132 circular dependency cycles in cattool JS bundle#4530

refactor: eliminate all 132 circular dependency cycles in cattool JS bundle#4530
riccio82 wants to merge 12 commits intodevelopfrom
fix/circular-deps

riccio82 commented Apr 24, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 24, 2026

Uh oh!

Copilot AI Apr 24, 2026

Uh oh!

Copilot AI Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-const {execSync} = require('child_process')
-let cycles
-try {
-  const output = execSync(
-    'npx madge --circular --extensions js --json public/js/',
+const {execFileSync} = require('child_process')
+let cycles
+try {
+  const output = execFileSync(
+    process.execPath,
+    [
+      require.resolve('madge/bin/cli.js'),
+      '--circular',
+      '--extensions',
+      'js',
+      '--json',
+      'public/js/',
+    ],

Conversation

riccio82 commented Apr 24, 2026

Summary

Motivation

Approach

1. Modal Registry Pattern (132 → 81 cycles)

2. Sibling File Extractions (81 → 25 cycles)

3. Lazy-Require Pattern (25 → 0 cycles)

4. CI Guard

Files Changed

Verification

Notes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants