Skip to content

🐛 fix: bypass DAO cache in isSegmentDisabled to prevent stale disabled … #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mauretto78 wants to merge 1 commit into
base: develop
Choose a base branch
from
+1 −1
Open

🐛 fix: bypass DAO cache in isSegmentDisabled to prevent stale disabled … #4552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Controller/Traits/SegmentDisabledTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ protected function isSegmentDisabled(int $id_job, int $id_segment): bool

// retrieve from cache fails, we need to check the database and update the cache accordingly
if (empty($cachedValue)) {
$metadataList = SegmentMetadataDao::get($id_segment, 'translation_disabled');
$metadataList = SegmentMetadataDao::get($id_segment, 'translation_disabled', 0);
$metadata = $metadataList[0] ?? null;
$isDisabled = (($metadata->meta_value ?? '0') === '1');
Comment on lines 52 to 55
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isSegmentDisabled()'s cache-miss path behavior changed (DAO cache bypass via ttl=0), but the existing unit tests for this trait only cover the Redis-hit path and skip DB/DAO interactions. Please add coverage for the cache-miss branch (e.g., by extracting the SegmentMetadataDao::get(...) call into an overridable method or injecting a DAO so the test can assert the ttl=0 behavior without a real DB).

Copilot uses AI. Check for mistakes.
$this->_setInCacheMap($cache['key'], $cache['query'], [$isDisabled ? 1 : 0]);
Expand Down
Loading