-
Notifications
You must be signed in to change notification settings - Fork 27
Modernize packaging #1974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize packaging #1974
Conversation
ca9615f to
b0c585f
Compare
|
@tschaume this should be more or less ready. To make sure everything is still working once deployed, can I try this out on a local deployment, or would the change from datetime to semantic versioning make that impossible (guessing the server is still using datetime)? |
tschaume
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks much, @esoteric-ephemera! Looks great! Other than a small comment, I think you can go ahead and try this in a local docker-compose stack with an rc version. I don't think the change in version format should be a problem - I can't recall why I decided on date-formatted versioning, maybe only because I wanted to automatically see when the new API was deployed the last time. It never really worked well and isn't needed anymore these days.
78e8587 to
a31a970
Compare
Had difficulty installing the contribs client without using
--config-settings editable_mode=compat. This PR just:setup.pyto apyproject.tomlpragmawithpyupgradeMP_API_KEYin env to allow users to set only one common API keyNaNto dimensionless (str()) unit conversionDidn't migrate setup.py --> pyproject.toml for namespaces which aren't published to pypi, but happy to do so if that's useful