Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
+ Coverage 66.72% 66.85% +0.13%
==========================================
Files 50 50
Lines 2777 2767 -10
==========================================
- Hits 1853 1850 -3
+ Misses 924 917 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… and clean up use_document_model boilerplate
Collaborator
Author
|
@tschaume ready for review whenever you get a chance! |
tschaume
reviewed
Oct 24, 2025
Member
tschaume
left a comment
There was a problem hiding this comment.
So much cleaner! Thank you. Just a couple of minor questions.
tschaume
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes related to serialization behavior changes that started in
emmet-core==0.86.0rc0, ensuring compatibility with emmet-core==0.86.0rc1 here.Summary:
materialsendpoint. This was probably previously an issue withmonty_decode=FalsetooMPDataDocobjects, + add a.getmethod. Reducesuse_document_modelboilerplate and permitspandas-like parity between dot-notation and key-item access