Skip to content

Ensure MPIDs are returned by find_structure#1026

Merged
tschaume merged 2 commits into
mainfrom
fix/1025
Oct 28, 2025
Merged

Ensure MPIDs are returned by find_structure#1026
tschaume merged 2 commits into
mainfrom
fix/1025

Conversation

@esoteric-ephemera
Copy link
Copy Markdown
Collaborator

Closes #1025 by validating IDs at the end of a call to find_structure

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.29%. Comparing base (5ecebec) to head (52956a2).
⚠️ Report is 248 commits behind head on main.

Files with missing lines Patch % Lines
mp_api/client/routes/materials/materials.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
+ Coverage   66.85%   67.29%   +0.43%     
==========================================
  Files          50       50              
  Lines        2767     2770       +3     
==========================================
+ Hits         1850     1864      +14     
+ Misses        917      906      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tschaume tschaume merged commit 44eca78 into main Oct 28, 2025
4 checks passed
@tschaume tschaume deleted the fix/1025 branch October 28, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: MPRester methods "find_structure" returns material_id in a wrong style

3 participants