-
Notifications
You must be signed in to change notification settings - Fork 78
update XAS type adapter + sync main into develop #1380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1380 +/- ##
========================================
Coverage 86.01% 86.02%
========================================
Files 229 229
Lines 17900 17908 +8
========================================
+ Hits 15397 15405 +8
Misses 2503 2503 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@tsmathis I want to try putting out a release of emmet-core soonish to make sure the pydantic warnings get suppressed. This PR should bring |
|
Do you need an immediate release to test the pydantic warnings? Can you test locally? or wait until the deployment cycle starts? And don't worry about syncing develop back, I'll handle that during getting the deployment ready (need to do dependency upgrades, etc., prior to going back to main) |
|
Sure that's also fine by me - have already tested locally and confirmed those warnings are suppressed. Do you want me to back this out just to the serde change, or leave the history synced up with |
|
Hmm, is this the final emmet PR you want in for this deployment? If so, the sync is fine. |
|
Could also do #1379 but that's a pretty significant change - superficially, nothing seems impacted there but hard to say |
|
Lets do that one in next deployment. We'll do a shorter cycle so there is less total area to look at prior to deploying |
|
OK to unblock some side projects, let's do #1296 first then this one? |
|
sure, all sounds good. In that case can you roll back the |
6a48ce1 to
8eda886
Compare
PydanticSerializationUnexpectedValuewarnings