Skip to content

Conversation

@esoteric-ephemera
Copy link
Collaborator

@esoteric-ephemera esoteric-ephemera commented Jan 21, 2026

  • Minor update to XAS serde to suppress more PydanticSerializationUnexpectedValue warnings
  • Add changes from main into develop

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.02%. Comparing base (4f96ff5) to head (a951bfd).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1380   +/-   ##
========================================
  Coverage    86.01%   86.02%           
========================================
  Files          229      229           
  Lines        17900    17908    +8     
========================================
+ Hits         15397    15405    +8     
  Misses        2503     2503           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@esoteric-ephemera esoteric-ephemera changed the title update XAS type adapter update XAS type adapter + sync main into develop Jan 21, 2026
@esoteric-ephemera
Copy link
Collaborator Author

@tsmathis I want to try putting out a release of emmet-core soonish to make sure the pydantic warnings get suppressed. This PR should bring develop up to date with main's history - once it's merged, I'll merge develop back into main.

@tsmathis
Copy link
Collaborator

Do you need an immediate release to test the pydantic warnings? Can you test locally? or wait until the deployment cycle starts?

And don't worry about syncing develop back, I'll handle that during getting the deployment ready (need to do dependency upgrades, etc., prior to going back to main)

@esoteric-ephemera
Copy link
Collaborator Author

Sure that's also fine by me - have already tested locally and confirmed those warnings are suppressed. Do you want me to back this out just to the serde change, or leave the history synced up with main?

@tsmathis
Copy link
Collaborator

tsmathis commented Jan 21, 2026

Hmm, is this the final emmet PR you want in for this deployment? If so, the sync is fine.
Otherwise I'd say to get the other PRs in, and then we sync.

@esoteric-ephemera
Copy link
Collaborator Author

Could also do #1379 but that's a pretty significant change - superficially, nothing seems impacted there but hard to say

@tsmathis
Copy link
Collaborator

Lets do that one in next deployment. We'll do a shorter cycle so there is less total area to look at prior to deploying

@esoteric-ephemera
Copy link
Collaborator Author

OK to unblock some side projects, let's do #1296 first then this one?

@tsmathis
Copy link
Collaborator

sure, all sounds good.

In that case can you roll back the main sync and I'll handle the syncing during releasing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants