Skip to content

Change Inline Helptexts and placeholders#1112

Merged
AltamashShaikh merged 12 commits into
5.x-devfrom
PG-5068-change-inline-helptexts
May 11, 2026
Merged

Change Inline Helptexts and placeholders#1112
AltamashShaikh merged 12 commits into
5.x-devfrom
PG-5068-change-inline-helptexts

Conversation

@maxtaube
Copy link
Copy Markdown

@maxtaube maxtaube commented May 5, 2026 •
edited
Loading

Description

Please reference the Ticket description and attached Document for the Tickets in Jira.

PG-5068

  • Added/updated inline help text for name and description fields on containers, tags, triggers, variables, and versions (new keys, old preserved).
  • Registered the new translation keys for client-side use.

PG-5021

  • Updated placeholder text for container and version name/description fields. Tags, triggers, and variables retain their type-based placeholders.
  • Containers: moved the Context field below the Description field.
  • Adjusted description textarea heights across all entities.

Checklist

  • [✔/✖] Tested locally or on demo2/demo3?
  • [✔/✖/NA] New test case added/updated?
  • [✔/✖/NA] Are all newly added texts included via translation?
  • [✔/✖/NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [✔/✖/NA] Documentation updated?

AltamashShaikh
AltamashShaikh reviewed May 6, 2026
View reviewed changes
Comment thread lang/en.json Outdated
AltamashShaikh
AltamashShaikh reviewed May 6, 2026
View reviewed changes
Comment thread vue/src/Container/ContainerEdit.vue Outdated
AltamashShaikh
AltamashShaikh reviewed May 6, 2026
View reviewed changes
Comment thread lang/en.json Outdated
AltamashShaikh
AltamashShaikh reviewed May 6, 2026
View reviewed changes
Comment thread lang/en.json Outdated
AltamashShaikh
AltamashShaikh requested changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few comments around reducing duplicates, rest looks good to me.

@maxtaube maxtaube changed the title Change Inline Helptexts Change Inline Helptexts and placeholders May 8, 2026
Maximilian Taube added 2 commits May 8, 2026 16:29
Merge branch '5.x-dev' into PG-5068-change-inline-helptexts
bd89276 
# Conflicts:
#	tests/UI/expected-screenshots/ContainerTag_create_advanced_blocktrigger_created.png
#	tests/UI/expected-screenshots/ContainerTag_create_advanced_firetrigger_created.png
#	tests/UI/expected-screenshots/ContainerTag_create_advanced_firetrigger_error.png
#	tests/UI/expected-screenshots/ContainerTag_create_advanced_prefilled1.png
#	tests/UI/expected-screenshots/ContainerTag_create_advanced_prefilled2.png
#	tests/UI/expected-screenshots/ContainerTag_create_new_delete_custom_dimensions.png
#	tests/UI/expected-screenshots/ContainerTag_create_new_error.png
#	tests/UI/expected-screenshots/ContainerTag_create_new_prefilled.png
#	tests/UI/expected-screenshots/ContainerTag_create_new_type_selected.png
#	tests/UI/expected-screenshots/ContainerTag_create_new_with_custom_dimensions.png
#	tests/UI/expected-screenshots/ContainerTag_create_new_with_custom_dimensions_event.png
#	tests/UI/expected-screenshots/ContainerTag_create_new_with_custom_dimensions_goal.png
#	tests/UI/expected-screenshots/ContainerTag_create_new_with_ecommerce_checkbox.png
#	tests/UI/expected-screenshots/ContainerTag_create_new_with_goal_tracking_type.png
#	tests/UI/expected-screenshots/ContainerTag_custom_html_tag_write_user_not_editable.png
#	tests/UI/expected-screenshots/ContainerTag_custom_html_tag_write_user_not_editable_after_edit.png
#	tests/UI/expected-screenshots/ContainerTag_edit_through_list.png
#	tests/UI/expected-screenshots/ContainerTag_edit_trigger_directly_updated.png
#	tests/UI/expected-screenshots/ContainerTag_edit_updated_back_to_list.png
#	tests/UI/expected-screenshots/ContainerTag_edit_url.png
#	tests/UI/expected-screenshots/ContainerTag_edit_url_updated.png
#	tests/UI/expected-screenshots/ContainerTag_save_updated_with_custom_dimensions.png
#	tests/UI/expected-screenshots/ContainerTrigger_create_advanced_prefilled.png
#	tests/UI/expected-screenshots/ContainerTrigger_create_new_error.png
#	tests/UI/expected-screenshots/ContainerTrigger_create_new_prefilled.png
#	tests/UI/expected-screenshots/ContainerTrigger_create_new_type_selected.png
#	tests/UI/expected-screenshots/ContainerTrigger_edit_through_list.png
#	tests/UI/expected-screenshots/ContainerTrigger_edit_url.png
#	tests/UI/expected-screenshots/ContainerTrigger_edit_url_updated.png
#	tests/UI/expected-screenshots/ContainerTrigger_select_variable_filter.png
#	tests/UI/expected-screenshots/ContainerVariable_create_advanced_prefilled.png
#	tests/UI/expected-screenshots/ContainerVariable_create_new_error.png
#	tests/UI/expected-screenshots/ContainerVariable_create_new_prefilled.png
#	tests/UI/expected-screenshots/ContainerVariable_create_new_type_selected.png
#	tests/UI/expected-screenshots/ContainerVariable_custom_js_variable_write_user_not_editable.png
#	tests/UI/expected-screenshots/ContainerVariable_custom_js_variable_write_user_not_editable_after_edit.png
#	tests/UI/expected-screenshots/ContainerVariable_edit_through_list.png
#	tests/UI/expected-screenshots/ContainerVariable_edit_url.png
#	tests/UI/expected-screenshots/ContainerVariable_edit_url_updated.png
#	tests/UI/expected-screenshots/ContainerVersion_create_new.png
#	tests/UI/expected-screenshots/ContainerVersion_create_new_error.png
#	tests/UI/expected-screenshots/ContainerVersion_create_new_prefilled.png
#	tests/UI/expected-screenshots/ContainerVersion_create_new_submitted.png
#	tests/UI/expected-screenshots/ContainerVersion_edit_through_list.png
#	tests/UI/expected-screenshots/ContainerVersion_edit_url.png
#	tests/UI/expected-screenshots/ContainerVersion_edit_url_updated.png
#	tests/UI/expected-screenshots/ContainerVersion_publish_new_prefilled.png
#	tests/UI/expected-screenshots/ContainerVersion_publish_new_submitted.png
#	tests/UI/expected-screenshots/Container_create_new_error.png
#	tests/UI/expected-screenshots/Container_create_new_prefilled.png
#	tests/UI/expected-screenshots/Container_edit_url.png
#	tests/UI/expected-screenshots/Container_edit_url_updated.png
#	tests/UI/expected-screenshots/Container_edit_url_with_activelySyncGtmDataLayer.png
#	tests/UI/expected-screenshots/Container_edit_url_with_isTagFireLimitAllowedInPreviewMode.png
#	tests/UI/expected-screenshots/Container_edit_url_without_activelySyncGtmDataLayer.png
#	tests/UI/expected-screenshots/Container_edit_url_without_isTagFireLimitAllowedInPreviewMode.png
#	vue/dist/TagManager.umd.min.js
fix merge issue
3bb68b5
@maxtaube maxtaube requested a review from AltamashShaikh May 8, 2026 15:26
@maxtaube maxtaube self-assigned this May 8, 2026
lachiebol
lachiebol approved these changes May 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@lachiebol lachiebol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AltamashShaikh AltamashShaikh merged commit 9ac8bff into 5.x-dev May 11, 2026
6 of 7 checks passed
@AltamashShaikh AltamashShaikh deleted the PG-5068-change-inline-helptexts branch May 11, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltamashShaikh AltamashShaikh AltamashShaikh approved these changes

@lachiebol lachiebol lachiebol approved these changes

@brenthoneybone brenthoneybone Awaiting requested review from brenthoneybone

Assignees

@maxtaube maxtaube

Labels

Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxtaube @AltamashShaikh @lachiebol