Skip to content

fix randomly failing UI test #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgiehl wants to merge 5 commits into
base: 5.x-dev
Choose a base branch
from
Open

fix randomly failing UI test #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
60564b6
fix randomly failing UI test
sgiehl Aug 30, 2023
9d02a2c
add small timeout when sending values
sgiehl Aug 30, 2023
4357612
improve waiting for values to be set
sgiehl Sep 22, 2023
852d7c4
improve wait time when selecting dropdowns
sgiehl Sep 22, 2023
1d24785
Merge branch '5.x-dev' into fixtest
sgiehl Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/UI/ContainerVersion_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ describe("ContainerVersion", function () {
await capture.page(page, 'create_new_shown_in_list');
});

it('should be possible to publish new version', async function () {
it('should be possible to fill in publish new version form', async function () {
await page.click('.createNewVersion');
await setVersionName('v3.0');
await page.waitForTimeout(500);
Expand Down Expand Up @@ -234,6 +234,7 @@ describe("ContainerVersion", function () {
it('should open create version page when clicking on create a version now link', async function () {
await page.click('.createContainerVersionNow');
await capture.setTableRowHeight(page);
await page.waitForTimeout(250); // loading element sometimes needs longer to be fully hidden
pageWrap = await page.$('#content');
expect(await pageWrap.screenshot()).to.matchImage('version_none_exist_yet_create_now');
});
Expand Down
38 changes: 19 additions & 19 deletions tests/UI/form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,27 @@
* @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
*/

exports.sendFieldValue = async function (page, selector, text)
{
await page.evaluate((selector) => {
$(selector).val('').change();
}, selector);
exports.sendFieldValue = async function (page, selector, text) {
await page.evaluate((selector) => {
$(selector).val('').change();
}, selector);

// page.sendKeys(selector, text);
await page.waitForFunction(() => $(selector).val() === '');

await page.evaluate((selector, text) => {
$(selector).val(text).change();
}, selector, text);
await page.evaluate((selector, text) => {
$(selector).val(text).change();
}, selector, text);

await page.waitForTimeout(200);
await page.waitForFunction(() => $(selector).val() === text);
};
exports.selectValue = async function (page, field, title)
{
await page.evaluate((field) => {
$(field + ' input.select-dropdown').click()
}, field);
await page.waitForTimeout(800);
await page.evaluate((field, title) => {
$(field + ' .dropdown-content li:contains("' + title + '"):first').click()
}, field, title);
exports.selectValue = async function (page, field, title) {
await page.evaluate((field) => {
$(field + ' input.select-dropdown').click()
}, field);

await page.waitForFunction(() => $(field + ' .dropdown-content li:contains("' + title + '")').length() > 0);

await page.evaluate((field, title) => {
$(field + ' .dropdown-content li:contains("' + title + '"):first').click()
}, field, title);
};
Loading