Skip to content
This repository was archived by the owner on Jul 21, 2025. It is now read-only.

[IMP] Prevent bare line feed rejection errors#596

Merged
anoadragon453 merged 6 commits into
matrix-org:mainfrom
NICO-SOLUTIONS:imp-avoid_bare_line_feed
Jul 17, 2025
Merged

[IMP] Prevent bare line feed rejection errors#596
anoadragon453 merged 6 commits into
matrix-org:mainfrom
NICO-SOLUTIONS:imp-avoid_bare_line_feed

Conversation

@NICO-SOLUTIONS
Copy link
Copy Markdown
Contributor

@NICO-SOLUTIONS NICO-SOLUTIONS commented Jun 14, 2025

  • Use CRLF line endings to avoid 550 5.6.11 SMTP errors

Pull Request Checklist

  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fix a bug that prevented receiving messages from other servers." instead of "Move X method from EventStore to EventWorkerStore.".
    • Include 'Contributed by Your Name.' or 'Contributed by @your-github-username.' — unless you would prefer not to be credited in the changelog.
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off

- Use CRLF line endings to avoid 550 5.6.11 SMTP errors

Signed-off-by: Nils Coenen <nils.coenen@nico-solutions.de>
Copy link
Copy Markdown
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

I'm surprised this wasn't flagged earlier. I suppose most mail server implementations are forgiving of non-CRLF line endings?

Comment thread changelog.d/550-email-crlf.md Outdated
Comment thread sydent/util/emailutils.py
Comment thread changelog.d/550-email-crlf.md Outdated
Comment thread sydent/util/emailutils.py Outdated
@NICO-SOLUTIONS
Copy link
Copy Markdown
Contributor Author

Thank you for your contribution!

I'm surprised this wasn't flagged earlier. I suppose most mail server implementations are forgiving of non-CRLF line endings?

@anoadragon453
you´re welcome.

it is possible, that some mail providers accept it. I just noticed the problem with 365 Exchange accounts. Thats why is was trying to find the culprit. SHoudl be the right spot for the changes.

@anoadragon453
Copy link
Copy Markdown
Member

According to Python's docs, the recommended way to construct an email is:

In general, you will want to use the email package’s features to construct an email message, which you can then send via send_message(); see email: Examples.

But this is fine for now.

@anoadragon453
Copy link
Copy Markdown
Member

Packaging CI failure is unrelated to this PR.

@anoadragon453 anoadragon453 merged commit a70c7cb into matrix-org:main Jul 17, 2025
4 of 6 checks passed
@NICO-SOLUTIONS NICO-SOLUTIONS deleted the imp-avoid_bare_line_feed branch July 17, 2025 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants