Skip to content

If authentication failed, no steps completed #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kroeckx wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

If authentication failed, no steps completed #1094

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef926b8
If authentication failed, no steps completed
kroeckx Jul 21, 2021
147a77e
fixup! If authentication failed, no steps completed
kroeckx Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/14account/02deactivate.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,15 @@ sub matrix_deactivate_account

my $body = decode_json $resp->content;

assert_json_keys( $body, qw( error errcode params completed flows ));
assert_json_keys( $body, qw( error errcode params flows ));

my $errcode = $body->{errcode};

$errcode eq "M_FORBIDDEN" or
die "Expected errcode to be M_FORBIDDEN but was $errcode";

exists $body->{completed} and die "Got an unexpected 'completed' key";

Comment on lines +53 to +54
Copy link
Copy Markdown
Member

@richvdh richvdh Jul 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely convinced that the presence of completed should be a failure here.

I agree that completed should not be required.

Copy link
Copy Markdown
Contributor Author

@kroeckx kroeckx Jul 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the test I did against synapse was something else. It seems synapse returns: "completed":[], which makes sense.

I guess this is an other case where the specification isn't really clear.

Future->done(1);
});
};
Expand Down