Fix tests to work with Rust event#1423
Open
erikjohnston wants to merge 6 commits into
Open
Conversation
Synapse is now validating that events have this field, even if it doesn't contain anything
We want to test what happens when we receive a create event with an unknown room version. However, to do this we need to ensure that the membership event has the same format as v1 (as that is the default room version), otherwise the event won't parse.
MadLittleMods
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR element-hq/synapse#19701 ports the event class to Rust, which as a side-effect adds some extra validation when we parse the event. As such, when we create "fake" events in tests we need to make sure they are sufficiently valid to parse, otherwise we don't test what we wanted to test.