Skip to content

security+quality: TLS verification hardening, Dependabot, and CodeQL#7

Open
mkilijanek wants to merge 3 commits into
matrixleons:mainfrom
mkilijanek:upstream/pr-quality-security-20260309
Open

security+quality: TLS verification hardening, Dependabot, and CodeQL#7
mkilijanek wants to merge 3 commits into
matrixleons:mainfrom
mkilijanek:upstream/pr-quality-security-20260309

Conversation

@mkilijanek
Copy link
Copy Markdown
Contributor

Summary

This PR cherry-picks three low-risk commits from my fork to improve security posture and maintenance hygiene in upstream:

  1. b974ff1 (cherry-picked from 376168c): enforce certificate + hostname verification for upstream TLS client context.
  2. fd51431 (cherry-picked from 9307fa2): add Dependabot configuration for Python, Docker, and GitHub Actions.
  3. ab4ca43 (cherry-picked from 77f8c74): add advanced CodeQL workflow (security-and-quality) for Python.

Why these changes

  • TLS hardening removes insecure defaults (CERT_NONE, disabled hostname checks) and switches to trusted CA verification.
  • Dependabot reduces dependency drift and shortens exposure windows for known CVEs.
  • CodeQL gives continuous static analysis for security/quality regressions.

Scope and risk

  • Scope is intentionally narrow (1 runtime file + 2 GitHub config files).
  • No feature behavior changes outside TLS validation correctness.
  • CI configs are additive and do not alter release artifacts.

Validation

  • python3 -m py_compile evilwaf.py core/*.py chemistry/*.py
  • Cherry-picks were applied with -x to preserve provenance.

Follow-ups (optional, separate PRs)

  • Add lightweight test workflow once upstream test baseline is finalized.
  • Pin GitHub Action SHAs for stronger supply-chain hardening.

@mkilijanek
Copy link
Copy Markdown
Contributor Author

Master merge plan for this upstream improvement batch:

  1. Security baseline:
  1. Runtime fixes/features (ordered dependencies):
  1. Repo/process hygiene (can be merged after security+quality: TLS verification hardening, Dependabot, and CodeQL #7; mostly independent):

Suggested strategy:

If useful, I can also rebase/refresh any PR in this set after upstream merges start landing.

@matrixleons
Copy link
Copy Markdown
Owner

Your changes in interceptor.py break
the core MITM proxy functionality.

Test result:
nikto -h https://testfire.net
-useproxy http://127.0.0.1:8080

ERROR: Proxy error: error reading
HTTP response

EvilWAF uses self-signed certificates
for MITM — enforcing strict TLS
verification breaks this completely.

@matrixleons
Copy link
Copy Markdown
Owner

Please rethink !👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants