test: expose batch output to tests and harden test assertions#585
Open
antoniolocascio wants to merge 43 commits into
Open
test: expose batch output to tests and harden test assertions#585antoniolocascio wants to merge 43 commits into
antoniolocascio wants to merge 43 commits into
Conversation
## What ❔ Reimplement the hints for ecrecover from ethproofs. Instead of having a new full implementation of ecrecover, this PR introduces "hooks" for 3 secp256k1 field operations. These hooks have two implmentations: default, where the implementation is straightforward (same implementation as before this PR) and oracle-based, where we use the new callable oracles. This way, most of the logic for ecrecover is reused. Given that this is a critical part of the system, the PR includes: * PBT for "good" case (showing equivalence when using the right oracle) * Tests for the "bad" case (showing panics if the oracle lies) * Modifies the fuzz target for ecrecover to compare the forward and oracle runs. I've ran the fuzzer for over 1h without finding issues. <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted.
antoniolocascio
changed the title
Contributor
Benchmark report
|
antoniolocascio
changed the title
0xVolosnikov
approved these changes
Mar 23, 2026
antoniolocascio
force-pushed
the
alocascio-batch-prover-input-run
branch
2 times, most recently
from
4a9d958 to
de4da02
Compare
antoniolocascio
force-pushed
the
alocascio-batch-prover-input-run
branch
8 times, most recently
from
b6ce646 to
90c1a64
Compare
0xVolosnikov
force-pushed
the
alocascio-batch-prover-input-run
branch
from
90c1a64 to
153a5e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Exposes prover-input replay outputs in the test rig via last_executed_block_info(), including prover-input BlockOutput and BatchOutput.
Uses that to strengthen tests with proving-side assertions:
Why ❔
Is this a breaking change?
Checklist