Add strict channel tool flow coverage#612
Draft
nickmisasi wants to merge 1 commit intotrigger-mcp-with-botsfrom
Draft
Add strict channel tool flow coverage#612nickmisasi wants to merge 1 commit intotrigger-mcp-with-botsfrom
nickmisasi wants to merge 1 commit intotrigger-mcp-with-botsfrom
Conversation
Co-authored-by: Nick Misasi <nick13misasi@gmail.com>
🤖 LLM Evaluation ResultsOpenAI
❌ Failed EvaluationsShow 1 failuresOPENAI1. TestReactEval/[openai]_react_cat_message
Anthropic
❌ Failed EvaluationsShow 1 failuresANTHROPIC1. TestReactEval/[anthropic]_react_cat_message
This comment was automatically generated by the eval CI pipeline. |
Contributor
There was a problem hiding this comment.
Security Review: No findings
This PR contains:
- A single-line lint fix in
conversations/conversations.goconvertingWriteString(Sprintf(...))toFprintf(...)— functionally identical, no behavioral change. - ~317 lines of new test code covering the
channelToolsAutoRunEverywhereOnlytool-calling flow.
No production logic is added or modified beyond the stylistic refactor. No new attack surface, no data flow changes, no auth/authz impact.
Sent by Cursor Automation: Find vulnerabilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Expanded handler-level coverage for strict channel tool-calling flows that propagate
channelToolsAutoRunEverywhereOnlyfrom post props through tool approval/result handling, and fixed a lint-blockingstaticcheckissue in OAuth notification formatting.QA test steps:
gofmt -l conversations/tool_handling_test.go conversations/conversations.goGOTOOLCHAIN=go1.26.1 /tmp/golangci-lint-bin/golangci-lint run ./conversations/...go test -count=1 ./conversations/...Ticket Link
NONE
Screenshots
NONE
Release Note