Fix issue importing local TS files#38
Open
simonsmith wants to merge 1 commit into
Open
Conversation
Author
|
I've had a bit more a play with this, and I think this package needs more love in general to support Astro 5. So could be worth addressing that to begin with |
|
Fastify should be "pre-middleware", not "post-middleware". It breaks rest api design in general. This no longer works: Because Maybe there is another solution. Btw, it looks like code transformer / module resolution problem, so if it needs to be fixed by middleware reordering it most likely needs to be fixed in Vite or there should be the way to say "do after transform" or smth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the fix discovered by @patheticGeek in this discussion I've applied the same one here.
Running the test project in this comment now works as expected
fixes #21