Skip to content

fix: bootstrap acceptance verifiers #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthias-scale wants to merge 1 commit into from
Closed

fix: bootstrap acceptance verifiers #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/acceptance-verifiers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"schema": "acceptance-verifiers/v1",
"verifiers": [
{
"id": "herdr-check-ubuntu",
"check_name": "check (ubuntu-latest)"
}
]
}
4 changes: 2 additions & 2 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Run tests
test:
cargo nextest run --locked --status-level fail --final-status-level fail --failure-output final --success-output never
python3 -m unittest scripts.test_agent_detection_manifest_check scripts.test_changelog scripts.test_config_reference_check scripts.test_docs_translation_parity scripts.test_hermes_integration_asset scripts.test_package_windows_conpty scripts.test_pr_gate_workflow scripts.test_preview scripts.test_vendor_libghostty_vt scripts.test_vendor_portable_pty scripts.test_watch_pr_checks
python3 -m unittest scripts.test_acceptance_verifier_registry scripts.test_agent_detection_manifest_check scripts.test_changelog scripts.test_config_reference_check scripts.test_docs_translation_parity scripts.test_hermes_integration_asset scripts.test_package_windows_conpty scripts.test_pr_gate_workflow scripts.test_preview scripts.test_vendor_libghostty_vt scripts.test_vendor_portable_pty scripts.test_watch_pr_checks
just integration-assets-test
just plugin-marketplace-test

Expand Down Expand Up @@ -38,7 +38,7 @@ windows-lint:
# Check formatting + run unit tests + Windows target lint + maintenance script tests
[unix]
check: ci windows-lint
python3 -m unittest scripts.test_agent_detection_manifest_check scripts.test_changelog scripts.test_config_reference_check scripts.test_docs_translation_parity scripts.test_hermes_integration_asset scripts.test_package_windows_conpty scripts.test_pr_gate_workflow scripts.test_preview scripts.test_vendor_libghostty_vt scripts.test_vendor_portable_pty scripts.test_watch_pr_checks
python3 -m unittest scripts.test_acceptance_verifier_registry scripts.test_agent_detection_manifest_check scripts.test_changelog scripts.test_config_reference_check scripts.test_docs_translation_parity scripts.test_hermes_integration_asset scripts.test_package_windows_conpty scripts.test_pr_gate_workflow scripts.test_preview scripts.test_vendor_libghostty_vt scripts.test_vendor_portable_pty scripts.test_watch_pr_checks
@echo "docs reminder: if this changes user-facing behavior, make sure the relevant release docs are updated or called out before release."

# Run independent final verification concurrently and print one summary.
Expand Down
31 changes: 31 additions & 0 deletions scripts/test_acceptance_verifier_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import json
import unittest
from pathlib import Path


REPO_ROOT = Path(__file__).resolve().parent.parent
REGISTRY_PATH = REPO_ROOT / ".github" / "acceptance-verifiers.json"
CI_WORKFLOW_PATH = REPO_ROOT / ".github" / "workflows" / "ci.yml"


class AcceptanceVerifierRegistryTests(unittest.TestCase):
def test_registry_allows_the_trusted_ubuntu_herdr_check(self) -> None:
registry = json.loads(REGISTRY_PATH.read_text(encoding="utf-8"))

self.assertEqual(registry["schema"], "acceptance-verifiers/v1")
self.assertEqual(
registry["verifiers"],
[{
"id": "herdr-check-ubuntu",
"check_name": "check (ubuntu-latest)",
}],
)

workflow = CI_WORKFLOW_PATH.read_text(encoding="utf-8")
self.assertIn("name: check (${{ matrix.os }})", workflow)
self.assertIn("- os: ubuntu-latest", workflow)
self.assertIn("run: just ci '${{ matrix.nextest_filter }}'", workflow)


if __name__ == "__main__":
unittest.main()
Loading