feat(ui): sidebar groups, dock editor, worklist rows [no-ticket] - #46
Merged
Conversation
source commit: 8605133
The Blocked and Pinned groups shipped with header rows that reserved a line but never drew one, so the groups read as unexplained gaps above the tree. Paint them with the same chevron a space row uses, and make that chevron real: clicking a header folds its group away, count kept so the header still says how much is hidden. The tree earns a Spaces header -- and a fold of its own -- whenever a group sits above it.
The Blocked and Pinned groups repeated the tree's own row template -- two lines ending in claude or codex -- which answers a question nobody asks of a gate. A grouped row is now a single line: state dot, thread title, then the space it belongs to. Cards carry their row index so a pane listed both in a group and in the tree renders each row in its own shape instead of twice in the first one's.
source commit: f92bc73
The canonical closing-block integration assets live under src/integration/assets/closing-block/. The demo copy is an obsolete v1 duplicate and is no longer referenced by the build or test recipes.
Keep dock layout and focus attach-local while retaining editor PTYs as server runtime resources.
Return structured results when UI projections diverge instead of panicking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #38. The original PR head could not be changed through GitHub's pull-request API, so this repaired head is submitted as a replacement.
Summary
fork/pr-basedemo/duplicate; canonical payload-v2 closing-block assets remain undersrc/integration/assets/closing-block/Rebase
4f82ffc18ff3cca4d41381b4eb856b05b53ae1d8725cf298d03b7c353b57e4d1704aed1e22e98010Validation
just check-parallelpasses all six lanes: lint, Rust/nextest, Windows lint, maintenance, integrations, and marketplaceAC5/AC6 repair evidence
server::headless::tests::full_app_background_client_does_not_resize_shared_dock_editor_runtimerenders two attached full-app clients with different viewports(100x30, dock 24)and(160x45, dock 48), both with the editor dock open. Red-first at the prior head printedbefore=(2, 10), after=(28, 22), proving the background client resized the shared editor PTY. On the repaired head, the test records exactly one resize, owned by the foreground client.DockPresentationStateand view geometry, while the shared editor PTY is sized only from the foreground client's layout. The six obsoletecrate::ui::dockforwarding aliases were removed; server cursor projection remains on the neutralsrc/server/render_stream.rssurface.handle_tab_pinreturns structuredtab_not_foundwhen tab projection returnsNone;api_tab_pin_projection_divergence_returns_structured_errorexercises that divergent-invariant path.mobile_switcher_target_for_rowreturnsNonefor section headers instead ofunreachable!;mobile_switcher_section_header_is_non_panickingcovers it.api_tab_pin_toggle_flips_pinned_flagandmobile_switcherfocused suites remain green.Repair commits:
473d45459dec5816467fbe3f542967b4fe29e514— fix shared dock editor resize ownership for divergent full-app clients5c67ba2f4206bbd770a443cdd74976f7879bdd28— AC5 boundary splitf6228ccc5a4553882da849104c6647da3b2c7751— AC6 panic removaldf4f6a3f317e3162935f1fd65ae8a89f0f45197b— remove misleading dock-editor forwarding aliases and track AC5 ownership deferral