🛡️ Sentinel: [CRITICAL] Fix SQL injection in internal/storage/sqlite.go#90
🛡️ Sentinel: [CRITICAL] Fix SQL injection in internal/storage/sqlite.go#90mattjoyce wants to merge 1 commit into
Conversation
Co-authored-by: mattjoyce <278869+mattjoyce@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
TestPrivsepNegativeSuite drops one worker and probes the whole surface — age key, config, state DB, and a SIBLING worker's dir — asserting EACCES on all, plus a positive control (own dir writable). Two different workers (never default/default) so the cross-worker probe can't pass trivially; within-default residual noted, not claimed. CI builds the test binary and runs the privileged privsep tests under sudo (they skip as non-root — skip is never a pass), making the wall a real CI gate.
TestPrivsepNegativeSuite drops one worker and probes the whole surface — age key, config, state DB, and a SIBLING worker's dir — asserting EACCES on all, plus a positive control (own dir writable). Two different workers (never default/default) so the cross-worker probe can't pass trivially; within-default residual noted, not claimed. CI builds the test binary and runs the privileged privsep tests under sudo (they skip as non-root — skip is never a pass), making the wall a real CI gate.
1 participant
🛡️ Sentinel: [CRITICAL] Fix SQL injection in internal/storage/sqlite.go
🚨 Severity: CRITICAL
💡 Vulnerability: SQL injection via unparameterized string concatenation in PRAGMA table_info queries.
🎯 Impact: Attackers could potentially execute arbitrary SQLite queries by manipulating the table name input.
🔧 Fix: Replaced
fmt.Sprintfwith SQLite's table-valued functionpragma_table_info(?), allowing for safe parameterized queries.✅ Verification: Ran
go test -v ./internal/storage/...and confirmed all tests pass. Included a new learning entry in.jules/sentinel.md.PR created automatically by Jules for task 8871290124125993327 started by @mattjoyce