Skip to content

Fix Claude Desktop config overwrite when using save panel #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sciencemanx wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −2
Open

Fix Claude Desktop config overwrite when using save panel #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions App/Integrations/ClaudeDesktop.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,10 +259,26 @@ private func updateConfig(
throw ClaudeDesktop.Error.noLocationSelected
}

// Create the file first
// The save panel grants us access to the selected URL, so re-read any
// existing contents to merge rather than overwrite.
log.debug("Creating configuration at selected URL: \(selectedURL.path)")
do {
try writeConfig(updatedConfig, to: selectedURL)
var configToWrite = updatedConfig
if FileManager.default.fileExists(atPath: selectedURL.path) {
log.debug("Selected file exists, re-reading to merge existing config")
let existingData = try Data(contentsOf: selectedURL)
let existingConfig = try jsonDecoder.decode([String: Value].self, from: existingData)
// Start from the existing config and upsert iMCP into it
configToWrite = existingConfig
if var mcpServers = existingConfig["mcpServers"]?.objectValue {
mcpServers["iMCP"] = imcpServerValue
configToWrite["mcpServers"] = .object(mcpServers)
} else {
configToWrite["mcpServers"] = .object(["iMCP": imcpServerValue])
}
}

try writeConfig(configToWrite, to: selectedURL)

// Then create the security-scoped bookmark
log.debug("Creating security-scoped access for selected URL")
Expand Down