Say which silence it is when the dashboard goes quiet - #39
Merged
Merged
Conversation
A vendor outage and a broken redirect end the same way here: every chip freezes and the display cannot tell you which one happened. The vendor sensor from #19 is the only thing that separates them, and the dashboard was not reading it. The liveness chip now names the suspect when it goes stale, and a card appears while the vendor is unreachable to say that the sump is still being watched but the phone app is deaf. Neither takes up space while things are working, which is deliberate: reachability is on nearly all the time, and a tile that reads green for months is one you stop reading. The chip's wording keeps the past tense. Nothing is forwarded while the device is quiet, so the verdict freezes with it, and what it reports is the last answer we got rather than a live one. That answer was taken at about the moment the reports stopped, which is the question being asked. Closes #28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A vendor outage and a broken redirect look identical on the dashboard: both end with every chip stale.
binary_sensor.pumpspy_local_vendor_reachablehas been able to tell them apart since #19, and the dashboard never read it.Two changes, neither of which takes up space while things are working:
No permanent tile, which answers the issue's open question. Vendor reachability is on essentially all the time, and something that reads green for months is something you stop reading.
test_dashboard.pyneeded two adjustments. The vendor sensor belongs to the integration's own service device, so it has no device id in it and it isn't built from an entity description: the known-id set is rebuilt from descriptions only, and every referenced id had to contain theyour_device_idplaceholder. Both now allow the two service entities by name, listed one by one rather than exempting anything that lacks a device id, which would exempt a typo too. A new test pins the coupling, checking the raw text as well as the parsed YAML because one of the two references lives inside a Jinja template the entity walk can't see.Verified on the live install, not just in tests:
binary_sensor.pumpspy_local_vendor_reachableconfirmed present in/api/states, which is the failure this would otherwise hit silently: a wrong id means the card simply never appears.One gap, stated plainly: the card itself hasn't been seen on screen, because that needs a real vendor outage and Chrome couldn't reach the instance to screenshot it. Its structure is identical to the three conditional alert cards already running in production.
Closes #28