Correct what the pump alerts are actually tied to - #42
Merged
Merged
Conversation
The note saying these are not a pump event was wrong. Ten of the thirteen in fourteen days of the shim's log are followed by a run report 10 to 12 seconds later, and yesterday's resolved into a recorded 10.0 s backup self-test. The three that were not all sit beside repeated login attempts. The tempting reading is that the alert is sent when the pump starts, which would be the "running now" signal this protocol is supposed to lack. It is not proven and cannot be yet: every backup run ever seen here ran 10.0 to 12.2 seconds, so a start-of-run alert and a fixed delay in front of the report are indistinguishable. It needs a run of some other length, which needs water this pit does not currently hold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#40 said
/pump_outlet_alertswas not a pump event, on the grounds that every occurrence sat inside the device's reconnect burst. That was reading half the pattern.Ten of the thirteen occurrences in fourteen days of the shim's access log are followed by a
/bbs_json10 to 12 seconds later, and yesterday's resolved into a recorded 10.0 s backup self-test. The three that were not all sit beside repeated/oauth/tokenattempts, and one of those was tonight: motor current and an alert arrived, no run report followed.The tempting conclusion is that the alert is sent when the pump starts, which would be the "pump is running now" signal this protocol is documented as not having. This deliberately stops short of claiming that. Every backup run ever observed here lasted 10.0 to 12.2 seconds, so an alert sent at the start of a run and an alert sent with a fixed delay ahead of the report produce identical logs. Separating them needs a run of a different length, which needs water this pit does not hold with the ground dry, so the answer waits on a wetter spring rather than on any work.
Docstring only, no behaviour change.