Rebased disasm feature from themadinventor/my#20
Rebased disasm feature from themadinventor/my#200kk28 wants to merge 9 commits intomatwey:masterfrom
Conversation
|
|
||
| Port = namedtuple("Port", ["node", "id", "creation"]) | ||
|
|
||
| Pid = namedtuple("Pid", ["node", "id", "serial", "creation"]) |
There was a problem hiding this comment.
Pid type is removed forever. This is not what we want.
pybeam/erlang_types.py
Outdated
| def __eq__(self, other): | ||
| return self._value == other.value | ||
| def __repr__(self): | ||
| return "<<%s>>" % self._value |
There was a problem hiding this comment.
Here you revert obsoleted implementation. I think it is better leave erlang_types as is, or you may prepare separate PR implementing __str__ and __repr__ for String and Binary types.
|
I am really sorry for being silent on this. I'll return to reviewing this PR as soon as I will have time. |
|
@0kk28 I know that my silence might be disappointing a bit. But frankly speaking, I don't know where to start with to fit this code into the package. Lets just rewrite |
| fname = sys.argv[1] if len(sys.argv) > 1 else '/usr/lib/erlang/lib/compiler-4.8.1/ebin/beam_dict.beam' | ||
| b = pybeam.BeamFile(fname) | ||
|
|
||
| print '# Module: %s' % b.modulename |
There was a problem hiding this comment.
Do we really use Python 2 syntax here in 2025?
3 participants
This PR rebases the disasm functionality from the outdated themadinventor/my branch onto the latest matwey/master.