Fix mock handler on Mautic 4#5
Fix mock handler on Mautic 4#5dennisameling wants to merge 1 commit intomautic:mautic-3from dennisameling:fix-m3-mock-handler
Conversation
|
@dennisameling can you push the branch and I will then make it default and apply the branch protection rules! Guessing we should remove the 2 branch? Or keep it for posterity?! |
|
@RCheesley sure thing, here it is: https://github.com/mautic/plugin-helloworld/tree/mautic-4 - let's remove the 2 branch indeed! |
|
Done! |
|
Just tried to reproduce this in Mautic 4 (features branch) PHP 7.4 and am not able to get the error you mentioned after installing the plugin at command line and then running the command - tried it a few times - have not applied this PR. ruth.cheesley@MacBookPro-RuthCheesley plugins % ddev exec bin/console mautic:integrations:sync helloworld Totally possible that I missed a step someplace! |
NOTE: we probably need a
mautic-4branch and make that the default 😊 CC @RCheesleybin/console mautic:integrations:sync helloworldresults in the following error on Mautic 4:This PR fixes that!
Steps to reproduce:
gh repo clone mautic/mautic, make sure you're on thefeaturesbranch (which is Symfony 4)cd plugins && gh repo clone mautic/plugin-helloworld HelloWorldBundlerm -rf ../var/cachebin/console mautic:integrations:sync helloworld, you'll run into the error mentioned above