Upgrade rubocop#82
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades RuboCop from version 1.31 to 1.81 and migrates all custom cops to use the modern RuboCop::Cop::Base API.
- Updates RuboCop dependency from 1.31 to 1.81
- Migrates all custom cops from deprecated
RuboCop::Cop::CoptoRuboCop::Cop::Base - Updates test expectations to match RuboCop 1.81's offense message format (which prefixes cop names)
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mavenlint.gemspec | Updates RuboCop development dependency from 1.31 to 1.81 |
| Gemfile.lock | Updates RuboCop and related dependencies, including ast, parser, rubocop-ast, and new dependencies like json, language_server-protocol, lint_roller, prism, and unicode-emoji |
| lib/rubocop/cop/mavenlint/use_fast_capybara_matchers.rb | Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base |
| lib/rubocop/cop/mavenlint/use_application_record.rb | Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base |
| lib/rubocop/cop/mavenlint/use_application_controller.rb | Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base |
| lib/rubocop/cop/mavenlint/use_api_controller.rb | Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base |
| lib/rubocop/cop/mavenlint/unsafe_mass_assignment.rb | Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base |
| lib/rubocop/cop/mavenlint/require_slow_helpers.rb | Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base |
| lib/rubocop/cop/mavenlint/no_dependent_destroy_account.rb | Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base |
| lib/rubocop/cop/mavenlint/direct_factory_bot_invocation.rb | Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base |
| lib/rubocop/cop/mavenlint/bigint_for_migration_keys.rb | Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base |
| lib/rubocop/cop/mavenlint/belongs_to_dependent_option.rb | Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base |
| spec/rubocop/cop/mavenlint/use_fast_capybara_matchers_spec.rb | Updates expected offense messages to include cop name prefix required by RuboCop 1.81 |
| spec/rubocop/cop/mavenlint/use_application_record_spec.rb | Updates expected offense messages to include cop name prefix required by RuboCop 1.81 |
| spec/rubocop/cop/mavenlint/use_application_controller_spec.rb | Updates expected offense messages to include cop name prefix required by RuboCop 1.81 |
| spec/rubocop/cop/mavenlint/use_api_controller_spec.rb | Updates expected offense messages to include cop name prefix required by RuboCop 1.81 |
| spec/rubocop/cop/mavenlint/unsafe_mass_assignment_spec.rb | Updates expected offense messages to include cop name prefix required by RuboCop 1.81 |
| spec/rubocop/cop/mavenlint/require_slow_helpers_spec.rb | Updates expected offense messages to include cop name prefix required by RuboCop 1.81 |
| spec/rubocop/cop/mavenlint/no_dependent_destroy_account_spec.rb | Updates expected offense messages to include cop name prefix required by RuboCop 1.81 |
| spec/rubocop/cop/mavenlint/direct_factory_bot_invocation_spec.rb | Updates expected offense messages to include cop name prefix required by RuboCop 1.81 |
| spec/rubocop/cop/mavenlint/bigint_for_migration_keys_spec.rb | Updates expected offense messages to include cop name prefix required by RuboCop 1.81 |
| spec/rubocop/cop/mavenlint/belongs_to_dependent_option_spec.rb | Updates expected offense messages to include cop name prefix required by RuboCop 1.81 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
guanw88
approved these changes
Nov 6, 2025
guanw88
left a comment
Contributor
There was a problem hiding this comment.
Nice! Should we include a version bump with this change?
wjean24
approved these changes
Nov 6, 2025
arthurlm44
approved these changes
Nov 6, 2025
armandocerna
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.