Skip to content

Upgrade rubocop#82

Merged
diclophis merged 5 commits into
masterfrom
upgrade-rubocop
Dec 19, 2025
Merged

Upgrade rubocop#82
diclophis merged 5 commits into
masterfrom
upgrade-rubocop

Conversation

@diclophis

@diclophis diclophis commented Nov 6, 2025

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades RuboCop from version 1.31 to 1.81 and migrates all custom cops to use the modern RuboCop::Cop::Base API.

  • Updates RuboCop dependency from 1.31 to 1.81
  • Migrates all custom cops from deprecated RuboCop::Cop::Cop to RuboCop::Cop::Base
  • Updates test expectations to match RuboCop 1.81's offense message format (which prefixes cop names)

Reviewed Changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mavenlint.gemspec Updates RuboCop development dependency from 1.31 to 1.81
Gemfile.lock Updates RuboCop and related dependencies, including ast, parser, rubocop-ast, and new dependencies like json, language_server-protocol, lint_roller, prism, and unicode-emoji
lib/rubocop/cop/mavenlint/use_fast_capybara_matchers.rb Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base
lib/rubocop/cop/mavenlint/use_application_record.rb Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base
lib/rubocop/cop/mavenlint/use_application_controller.rb Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base
lib/rubocop/cop/mavenlint/use_api_controller.rb Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base
lib/rubocop/cop/mavenlint/unsafe_mass_assignment.rb Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base
lib/rubocop/cop/mavenlint/require_slow_helpers.rb Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base
lib/rubocop/cop/mavenlint/no_dependent_destroy_account.rb Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base
lib/rubocop/cop/mavenlint/direct_factory_bot_invocation.rb Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base
lib/rubocop/cop/mavenlint/bigint_for_migration_keys.rb Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base
lib/rubocop/cop/mavenlint/belongs_to_dependent_option.rb Migrates from RuboCop::Cop::Cop to RuboCop::Cop::Base
spec/rubocop/cop/mavenlint/use_fast_capybara_matchers_spec.rb Updates expected offense messages to include cop name prefix required by RuboCop 1.81
spec/rubocop/cop/mavenlint/use_application_record_spec.rb Updates expected offense messages to include cop name prefix required by RuboCop 1.81
spec/rubocop/cop/mavenlint/use_application_controller_spec.rb Updates expected offense messages to include cop name prefix required by RuboCop 1.81
spec/rubocop/cop/mavenlint/use_api_controller_spec.rb Updates expected offense messages to include cop name prefix required by RuboCop 1.81
spec/rubocop/cop/mavenlint/unsafe_mass_assignment_spec.rb Updates expected offense messages to include cop name prefix required by RuboCop 1.81
spec/rubocop/cop/mavenlint/require_slow_helpers_spec.rb Updates expected offense messages to include cop name prefix required by RuboCop 1.81
spec/rubocop/cop/mavenlint/no_dependent_destroy_account_spec.rb Updates expected offense messages to include cop name prefix required by RuboCop 1.81
spec/rubocop/cop/mavenlint/direct_factory_bot_invocation_spec.rb Updates expected offense messages to include cop name prefix required by RuboCop 1.81
spec/rubocop/cop/mavenlint/bigint_for_migration_keys_spec.rb Updates expected offense messages to include cop name prefix required by RuboCop 1.81
spec/rubocop/cop/mavenlint/belongs_to_dependent_option_spec.rb Updates expected offense messages to include cop name prefix required by RuboCop 1.81

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@guanw88 guanw88 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should we include a version bump with this change?

@diclophis diclophis merged commit 9b6ebc9 into master Dec 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants