skills: gate sweep-found fixes on reachability, and stop tests pinning undefined behavior - #1134
Merged
Conversation
…g undefined behavior Closes #1133
tend-agent
commented
Sep 3, 2026
tend-agent
left a comment
Collaborator
Author
There was a problem hiding this comment.
The three additions read cleanly against the flows they sit in — the triage section fits beside the existing skip-guard gate, and the review line is a distinct enough action (what to suggest vs. what to write) to be worth its own line rather than a duplicate. One inline suggestion on the nightly gate.
Replace the Rust-specific `pub` keyword with "public visibility" so the loophole-closer reads as applicable in every adopter's ecosystem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A nightly sweep on PRQL opened PRQL/prql#6250 for a real vector-sizing mismatch that no in-repo caller can trigger, and the collaborator rejected it: "While the change might fix theoretical future problems, it's not fixing a current problem." Nothing in the bundled skills asked the sweep to check that.
nightly's review checklist leads with "Bugs, logic errors, unhandled edge cases" and carries no reachability test;running-in-ci's Weighing a Fix raises the bar only for compute-saving changes, andtriage's reproduction gate never applies because a sweep has no report to reproduce. Reported by the PRQL bot in #1133.Three lines of guidance, no new machinery:
nightly— a gate on the checklist's bug line. Before a sweep-found defect becomes a PR, name the in-repo call path that reaches it. If none does, the finding is a note in the Step 9 summary. public visibility doesn't clear the bar on its own; a documented public surface on a published library does, and the PR body should name the contract rather than the keyword.triage— a fix-quality gate beside the existing "Don't 'fix' tests by adding skip guards". When a doc claim and the code disagree and which is wrong is still open, the finding is that question; a test pinning the current output turns unspecified behavior into a contract, so the eventual fix arrives looking like a regression. This is the second finding on the same PR: the bot answered a doc/code mismatch by asserting current output in a test, and the reviewer flagged it.review— the reviewer-side counterpart under Testing, one line: don't suggest that test either. Distinct action from thetriagegate (what to suggest vs. what to write), and a wrong inline suggestion is an outward action, so it's worth the line rather than relying on the author-side gate alone.Verification is
pre-commiton the three files (all hooks pass, including the bang-backtick and install-tend mirror guards) plusgenerator/tests/test_cross_file_contracts.py(15 passed). No regression test: nothing in the suite asserts skill prose, and these are prompt-text changes whose effect shows up in adopter run outcomes, not in CI.Closes #1133 — automated triage