Update logging Level and allow Sub Classing#10
Open
gatling822 wants to merge 2 commits intomaxant:masterfrom
Open
Update logging Level and allow Sub Classing#10gatling822 wants to merge 2 commits intomaxant:masterfrom
gatling822 wants to merge 2 commits intomaxant:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been using this awesome rules engine for almost 2 years thing have been great but recently we added more rule the performance started to degrade. We found that one improvement was to stop creating the log statement for every matched rule.
Second we found a use case where would would like to use more features of the MVEL sub system, and use the compiled rules and that are created in the Engine.java so adding the ability subclass the Engine.java would allow use to extend the functionality if needed.
Resolves #7