Infer modal props type for useModal#10
Open
lukasluecke wants to merge 1 commit into
Open
Conversation
Owner
|
I think this is a really nice idea. Would you mind fixing the build errors? A couple places in the reconciler I am passing a dummy function as Here is an example: Lines 514 to 516 in 3cb0344 I think it would be fine to export the const useModal = (() => null) as UseModal; |
Author
|
Sure, I'll look into it a bit more 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it might also make sense to change the default
<p = any>usages, so you actually have to specify the prop types? But for now this works as it is, so at least you don't need to specify the types twice 🙂