Dependabot/cargo/mongodb 3.0.1

[davidbayo10]

No description provided.

[maxcountryman]

This should implement create and I believe that's not easily possible with stock mongo.

See: #16

[davidbayo10]

Updating the MongoDB driver version should be separate from adapting to the new API of Tower Sessions. It shouldn't be coupled together, right?

[maxcountryman]

I disagree. There's no point in updating a broken implementation. If it can't be implemented then it should be abandoned altogether.

[davidbayo10]

I understand your point, but I'd argue that Tower Sessions doesn't force you to implement the create method, it just recommends it.

async fn create(&self, session_record: &mut Record) -> Result<()> {
    default_create(self, session_record).await
}

async fn default_create<S: SessionStore + ?Sized>(
    store: &S,
    session_record: &mut Record,
) -> Result<()> {
    tracing::warn!(
        "The default implementation of `SessionStore::create` is being used, which relies on \
         `SessionStore::save`. To properly handle potential ID collisions, it is recommended that \
         stores implement their own version of `SessionStore::create`."
    );
    store.save(session_record).await?;
    Ok(())
}

To wrap up and as a possible idea, I think the only way to avoid possible ID collisions is to generate our unique ids. Using UUIDs or MongoDB Object IDs could be enough.

I hope a viable solution could be found.

[maxcountryman]

It only doesn't require it for compatibility reasons (and in the near future it will be required). But make no mistake: any implementation that doesn't provide create is broken.