Adds features option to use either time or chrono for sqlx

[karuna]

Adds features option to use either time or chrono for sqlx

[maxcountryman]

Thanks for this. I can't publish it until later, but I'll go ahead and merge.

[maxcountryman]

Oops, I missed that this breaks feature unification. I'll have to roll this back. I'm not sure what the "right" approach is, but note that sqlx doesn't break feature unification so I'd prefer that we don't either. I'm going to revert this for the time being.

[abonander]

@maxcountryman I would recommend maybe just using the chrono feature, as it's lower in precedence than the time feature and will never override it.

Had we better understood feature unification when we were initially designing SQLx, we might have avoided this issue entirely, but the choice is rather ossified at this point.

Even once transact-rs/sqlx#3383 is fully implemented, I'm not sure what to do with the existing behavior except maybe force the user to pick an option.

[aschweig]

I had the idea to trivially take the outer-product of the various options, so one has both feature = "sqlite" and feature = "sqlite-chrono", and the latter introduces the SqliteChonoStore; and similarly for mysql, and prostgres . The feature (time or chrono) is simply passed on to sqlx without thinking too much -- though I am thinking maybe I just switch to time. (I lifted most of my work from PR #46)

https://github.com/aschweig/tower-sessions-stores/tree/chronofix/sqlx-store

[nicolasauler]

Hey guys, has this been fixed? Or, can we fix it?

[karuna]

Maybe use my fork: https://crates.io/crates/tower-sessions-sqlx-store-chrono