Fix build with PHP 8.6.0alpha2#252
Conversation
. The XtOffsetOf() alias of C’s offsetof() macro has been removed. Use
offsetof() directly.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the extension’s embedded-object offset calculations to use ChangesObject Offset Calculation
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request replaces the use of the XtOffsetOf macro with the standard offsetof macro in ext/maxminddb.c when calculating the offset of the std member in maxminddb_obj. This change is applied in both php_maxminddb_fetch_object and the module initialization function PHP_MINIT_FUNCTION(maxminddb). There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
horgh
left a comment
There was a problem hiding this comment.
Great, thank you! I found
php/php-src@7114314 about this.
. The XtOffsetOf() alias of C’s offsetof() macro has been removed. Use
offsetof() directly.
Summary by CodeRabbit