-
Notifications
You must be signed in to change notification settings - Fork 3
diff report for jan 2026 is posted #1537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @AndraMeer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the monthly GeoNames diff report for January 2026. It updates the documentation to include a new release note entry for this report and adds the corresponding CSV file containing detailed geographical data changes. This ensures that users have access to the latest updates incorporated into the GeoIP and GeoLite databases, providing transparency on how geographical data evolves over time. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Deploying dev-site with
|
| Latest commit: |
3b09990
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e425cbe9.dev-site-4ua.pages.dev |
| Branch Preview URL: | https://andram-diff-report-jan-2026.dev-site-4ua.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new release note for the January 2026 GeoNames monthly diff report and the associated CSV data file. My review, guided by the repository's documentation style guide, identified a few areas for improvement to ensure clarity and technical accuracy. Key findings include a broken link to the new CSV file, a mismatch between field names in the release note and the CSV file, and minor formatting issues like a missing period and missing final newlines in the new/modified files. Addressing these points will enhance the quality of the documentation for users.
content/geoip/release-notes/2026.md
Outdated
| {{</ release-note >}} | ||
|
|
||
| {{< release-note date="2026-01-14" title="GeoNames monthly diff report January 2026" >}} | ||
| [GeoNames monthly diff report (January 2026)](/csv-files/GeoNames-Monthly-Diff-Report-January-2026.csv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to the CSV file appears to be broken. The path /csv-files/... is incorrect. Based on the file's location at static/static/csv/..., the correct URL path in Hugo should be /static/csv/... to ensure the link works correctly for users.
| [GeoNames monthly diff report (January 2026)](/csv-files/GeoNames-Monthly-Diff-Report-January-2026.csv) | |
| [GeoNames monthly diff report (January 2026)](/static/csv/GeoNames-Monthly-Diff-Report-January-2026.csv) |
References
- Verify links point to the correct documentation section. (link)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works and has been working since we started doing these :)
content/geoip/release-notes/2026.md
Outdated
| - `subdivision_1_iso_code` | ||
| - `subdivision_2_iso_code` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field names subdivision_1_iso_code and subdivision_2_iso_code are listed, but the corresponding columns in the CSV file are old_subdivision_codes and new_subdivision_codes. To avoid confusion and maintain consistency, the documentation should accurately reflect the field names used in the data file.
| - `subdivision_1_iso_code` | |
| - `subdivision_2_iso_code` | |
| - `subdivision_codes` |
References
- Verify field descriptions match the field being documented (e.g., shipping field descriptions shouldn't reference billing). (link)
content/geoip/release-notes/2026.md
Outdated
| Note that the values for the `old_` and `new_` columns for a given field only | ||
| differ for the field defined in the `diff_in` column. | ||
|
|
||
| {{</ release-note >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is missing a newline character at the end. It is a best practice to end files with a newline for POSIX compatibility and to prevent potential issues with file processing tools.
References
- Remove trailing whitespace from lines. (link)
| geoname_id,1149698,1151416,Phetchaburi,Phetchaburi,Thailand,Thailand,TH,TH,76,76 | ||
| geoname_id,2638488,12262593,Saunderton,Saunderton,United Kingdom,United Kingdom,GB,GB,"ENG, BKM","ENG, BKM" | ||
| geoname_id,13274969,13280479,Pentre,Pentre,United Kingdom,United Kingdom,GB,GB,"WLS, FLN","WLS, FLN" | ||
| subdivision_codes,2659568,2659568,Moutier,Moutier,Switzerland,Switzerland,CH,CH,BE,JU No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dlieou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.