-
Notifications
You must be signed in to change notification settings - Fork 3
SCO-8420 Restore dev-site code formatting build #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCO-8420 Restore dev-site code formatting build #1541
Conversation
Summary of ChangesHello @mm-jpoole, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical issues within the dev-site's build and formatting infrastructure. It rectifies a failing GitHub Actions workflow responsible for code formatting and restores the functionality of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a failing build for the format:rawhtml script. The changes correctly add the necessary TypeScript compiler flags to the package.json script, update a related dependency, and add the build output directory to .gitignore. The repository's style guide is focused on documentation, so I've reviewed these code changes from a software engineering perspective. The fix is effective, and I have one suggestion to improve the maintainability of the package.json script by externalizing the compiler configuration.
tsc was compiling as CommonJS, causing an error. Now it compiles as a module.
required to prevent an error from stylelint
49ba06d to
9a55fd8
Compare
Deploying dev-site with
|
| Latest commit: |
9a55fd8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e12fe0c.dev-site-4ua.pages.dev |
| Branch Preview URL: | https://jpoole-sco-8420-restore-dev.dev-site-4ua.pages.dev |
https://linear.app/maxmind/issue/SCO-8420
The dev-site code formatting GitHub Actions build is currently failing.
In addition to fixing the failing build, this issue should fix the currently broken format:rawhtml npm script
Relevant run: https://github.com/maxmind/dev-site/actions/runs/21077857437/job/60624166377