Skip to content

Conversation

@mm-jpoole
Copy link
Contributor

https://linear.app/maxmind/issue/SCO-8420

The dev-site code formatting GitHub Actions build is currently failing.

In addition to fixing the failing build, this issue should fix the currently broken format:rawhtml npm script

Relevant run: https://github.com/maxmind/dev-site/actions/runs/21077857437/job/60624166377

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mm-jpoole, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses critical issues within the dev-site's build and formatting infrastructure. It rectifies a failing GitHub Actions workflow responsible for code formatting and restores the functionality of the format:rawhtml npm script. These changes are essential for maintaining consistent code style, ensuring automated checks pass, and supporting developer tooling.

Highlights

  • GitHub Actions Build Fix: Resolved a failing GitHub Actions build for dev-site code formatting, ensuring automated checks pass.
  • format:rawhtml Script Repair: Fixed the format:rawhtml npm script, which was previously broken, restoring its functionality for raw HTML formatting.
  • Dependency Update: Updated the baseline-browser-mapping dependency to version 2.9.15.
  • TypeScript Compilation Options: Modified the format:rawhtml script to include specific TypeScript compilation flags (--module NodeNext --moduleResolution NodeNext --target ES2022) for improved compatibility and build reliability.
  • Git Ignore Update: Added the dist/ directory to .gitignore to prevent compiled output from being committed to the repository.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a failing build for the format:rawhtml script. The changes correctly add the necessary TypeScript compiler flags to the package.json script, update a related dependency, and add the build output directory to .gitignore. The repository's style guide is focused on documentation, so I've reviewed these code changes from a software engineering perspective. The fix is effective, and I have one suggestion to improve the maintainability of the package.json script by externalizing the compiler configuration.

tsc was compiling as CommonJS, causing an error. Now it compiles as a module.
required to prevent an error from stylelint
@mm-jpoole mm-jpoole force-pushed the jpoole/sco-8420-restore-dev-site-code-formatting-build branch from 49ba06d to 9a55fd8 Compare January 16, 2026 21:35
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 16, 2026

Deploying dev-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a55fd8
Status: ✅  Deploy successful!
Preview URL: https://9e12fe0c.dev-site-4ua.pages.dev
Branch Preview URL: https://jpoole-sco-8420-restore-dev.dev-site-4ua.pages.dev

View logs

@mm-jpoole mm-jpoole merged commit d945a0b into main Jan 20, 2026
12 checks passed
@mm-jpoole mm-jpoole deleted the jpoole/sco-8420-restore-dev-site-code-formatting-build branch January 20, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants