Skip to content

Conversation

@xalopp
Copy link
Contributor

@xalopp xalopp commented Sep 19, 2025

Type of PR

  • Bugfix
  • New Feature
  • Other (explain): Support new PHP version 8.5

Breaking changes

  • Yes, this is a breaking change

Description

Be prepared for upcoming PHP 8.5 release

@xalopp
Copy link
Contributor Author

xalopp commented Sep 19, 2025

vimeo/psalm currently requires "php": "~8.1.31 || ~8.2.27 || ~8.3.16 || ~8.4.3"

Possible actions:

@xalopp xalopp marked this pull request as draft September 19, 2025 09:05
@xalopp
Copy link
Contributor Author

xalopp commented Sep 19, 2025

phan also needs an update to PHP 8.5: phan/phan#5066

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (93dad05) to head (cb779e0).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #226   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       147       147           
===========================================
  Files              8         8           
  Lines            669       669           
===========================================
  Hits             669       669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmoll
Copy link
Contributor

mmoll commented Sep 23, 2025

Let's wait for an official 8.5.0 (or .1) release, I'm quite sure all the dependencies will get appropriate updates until then.

Copy link
Contributor Author

@xalopp xalopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmoll I think this should be part of a own PR.
Fixes Issues reported by SonarQube:
https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions

Some of the used GitHub Actions are not up to date (slackapi/slack-github-action, technote-space/workflow-conclusion-action) which might also need attention.

@mmoll
Copy link
Contributor

mmoll commented Dec 4, 2025

@xalopp Could you open a separate PR to update the actions to newer versions and use the SHAs to shut up SonarCube?

@xalopp
Copy link
Contributor Author

xalopp commented Dec 5, 2025

Depends on #227
I remove the DRAFT-state from this PR, once #227 is merged and rebased in this PR

@mmoll
Copy link
Contributor

mmoll commented Dec 9, 2025

@xalopp please rebase :)

@xalopp xalopp force-pushed the php85 branch 2 times, most recently from 43e0d18 to fd4304d Compare December 10, 2025 16:07
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants