fix(launcher): usable stdio under pythonw - headless tray failed to bind the UI port#199
Merged
Conversation
…ind the UI port A detached pythonw start has sys.stdout/sys.stderr = None; uvicorn's default logging config writes to those streams, so the launcher's own uvicorn thread died before binding :11438 (observed live during the v0.7.0 install: ':11438 did not bind within 3.0s' with no traceback, tray icon up, dashboard dead). _ensure_streams() routes the missing streams into --log-file (or os.devnull) right after arg parsing, so every print/StreamHandler in the stack stays harmless when headless. 2 new tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.7.0 hotfix, caught during the local tray install: a detached pythonw start has sys.stdout/stderr = None, uvicorn's default loggers write to them, and the launcher's uvicorn thread died before binding :11438 (tray icon alive, dashboard dead, no traceback). _ensure_streams() gives the process usable streams (the --log-file, else devnull) right after arg parsing. 2 new tests; 52 passed across launcher suites.